Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC xml copyright license experiment #1285

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Nov 19, 2024
@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title Rfc xml copyright license experiment RFC xml copyright license experiment Nov 19, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the solution I would prefer, it is consistent with the rest of the XML with attribs.
References make it easy, we could even provide them with default creative common licenses. In the xmllib we could create an enum object where they can select the correct license or enter a custom string. As a user I would appreciate that, because for example all my project images have the same CC license.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The advantage if they have to enter the actual string that is displayed is that they don't have to keep track of a mapping and we do not need to resolve it in a step where we have the possibility that they used a reference that does not exist. However this can also be checked easily with SHACL so in the long term that is not a lot of work for us.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the option I like least.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this option least. When we have a reference we may as well put is as an attrib.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do not want to make a reference then I think this is the better option that writing it into the attribs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote against this one, because if anyone modifies the xml manually for unknown reasons, then we get an ugly result.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is personally my preferred version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too, I prefer this one. Thanks for the prototype, this helps to get a clear understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants