Add connect_timeout option for Schema Registry #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasch
previously approved these changes
Sep 6, 2023
dasch
approved these changes
Sep 7, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋
I'm creating this PR to add the ability of setting Excon's timeout connection option.
With this ability I wish to set a smaller timeout in case the schema registry is unavailable, so that we can have a "fail fast" approach.
I'd rather set the timeout to something like 10 seconds and retry 5 times, rather than having a timeout of 60 seconds (default value) with only 1 attempt.
Please feel free to provide any feedback you deem relevant.
Thanks 😁
Notes:
This was discussed in the past in #62.
My first PR (#196) had a different, not optimal, approach as noted by @dasch.