Auto release upon edit to CITATION.cff #124
Conversation
✅ Deploy Preview for strchive ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This was my easiest CI debug ever 😂 |
.github/workflows/make-release.yaml
Outdated
| for (const file of globSync("**/STRchive-*.json")) | ||
| renameSync(file, file.replace(".json", `_v${newVersion}.json`)); | ||
| for (const file of globSync("**/*STRchive-disease-loci*.bed")) | ||
| renameSync(file, file.replace("-loci", `-loci_v${newVersion}`)); |
There was a problem hiding this comment.
If you're going to keep the file names as they are, I'd change the _ to a . to be consistent with the other separators. As it is right now, it'd become e.g. T2T-chm13.STRchive-disease-loci_v2.1.0.TRGT.bed.
Ideally though, unless you don't want to make breaking changes or the current format is some kind of convention, I'd recommend renaming the files to e.g. STRchive-disease-loci_v2.1.0_T2T-chm13_TRGT.bed. To me that's more readable, understandable, and easily parsable with code, and will also group them together more nicely in alphabetical (most) file system views.
There was a problem hiding this comment.
Thanks for the reminder about file names @vincerubinetti
What about something like this?
File names in github:
STRchive-citations-test.json
STRchive-citations.json
STRchive-disease-loci.T2T-chm13.TRGT.bed
STRchive-disease-loci.T2T-chm13.bed
STRchive-disease-loci.hg19.TRGT.bed
STRchive-disease-loci.hg19.bed
STRchive-disease-loci.hg38.TRGT.bed
STRchive-disease-loci.hg38.bed
STRchive-loci.json
renaming:
// add version to artifact filenames
for (const file of globSync("**/STRchive-*.json"))
renameSync(file, file.replace("STRchive", `STRchive_v${newVersion}`));
for (const file of globSync("**/*STRchive-disease-loci*.bed"))
renameSync(file, file.replace("STRchive", `STRchive_v${newVersion}`));
Which would produce:
STRchive_v2.0.0-disease-loci.hg38.bed
There was a problem hiding this comment.
That looks better to me, though I'd still replace the _ with a .
There was a problem hiding this comment.
To be clear, I just mean that I'd be consistent with group vs. part separators. E.g.:
STRchive-v2.0.0-disease-loci.hg38.bed or STRchive.v2.0.0.disease-loci.hg38.bed or STRchive_v2.0.0_disease-loci_hg38.bed
|
Updated with more consistent naming and tested that all the scripts still work and I didn't break anything when I changed names. |
|
@vincerubinetti any additional feedback? |
Credit to @vincerubinetti for doing most of the work here. I just updated some file naming/matching