fix: blocked mnlistdiff processing #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
commented
Nov 25, 2024
Comment on lines
-124
to
-129
| long newHeight = ((CoinbaseTx) mnlistdiff.coinBaseTx.getExtraPayloadObject()).getHeight(); | ||
| block = blockChain.getBlock(mnlistdiff.getBlockHash()); | ||
|
|
||
| if(!isLoadingBootStrap && block.getHeight() != newHeight) | ||
| throw new ProtocolException("mnlistdiff blockhash (height="+block.getHeight()+" doesn't match coinbase blockheight: " + newHeight); | ||
|
|
There was a problem hiding this comment.
block = blockChain.getBlock(mnlistdiff.getBlockHash());Based on the logs, this line of code was probably taking too long. We don't really need it because if the block heights don't match, then neither will the block hashes which will be discovered later in the code.
HashEngineering
commented
Nov 25, 2024
Comment on lines
-268
to
-288
| // TODO: Remove with v21.0.1 | ||
| if (lock.isLocked()) { | ||
| log.warn("the lock is held. holdCount {}, queue length {}, held by this thread {}", lock.getHoldCount(), lock.getQueueLength(), lock.isHeldByCurrentThread()); | ||
| log.warn("the current thread is {} with stack trace:", Thread.currentThread().getName()); | ||
| StackTraceElement [] trace = lock.getOwner().getStackTrace(); | ||
| for (StackTraceElement e : trace) { | ||
| log.info(" {}", e); | ||
| } | ||
| log.warn("the lock is held by {} with stack trace:", lock.getOwner()); | ||
| trace = lock.getOwner().getStackTrace(); | ||
| for (StackTraceElement e : trace) { | ||
| log.info(" {}", e); | ||
| } | ||
| for (Thread thread : lock.getQueuedThreads()) { | ||
| log.info("queued thread: {}\n stack trace:", thread.getName()); | ||
| trace = thread.getStackTrace(); | ||
| for (StackTraceElement e : trace) { | ||
| log.info(" {}", e); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We don't need this deadlock detector anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only