Skip to content

feat: bidirectional references #487

feat: bidirectional references

feat: bidirectional references #487

Triggered via pull request January 23, 2025 12:54
Status Failure
Total duration 7m 2s
Artifacts

coverage.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 81 warnings
Code Coverage
Process completed with exit code 101.
this function has too many arguments (8/7): grovedb/src/lib.rs#L933
warning: this function has too many arguments (8/7) --> grovedb/src/lib.rs:933:5 | 933 | / fn verify_merk_and_submerks_in_transaction<'db, B: AsRef<[u8]>, S: StorageContext<'db>>( 934 | | &'db self, 935 | | merk: Merk<S>, 936 | | path: &SubtreePath<B>, ... | 941 | | grove_version: &GroveVersion, 942 | | ) -> Result<VerificationIssues, Error> { | |__________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/operations/proof/verify.rs#L228
warning: this function has too many arguments (8/7) --> grovedb/src/operations/proof/verify.rs:228:5 | 228 | / fn verify_layer_proof<T>( 229 | | layer_proof: &LayerProof, 230 | | prove_options: &ProveOptions, 231 | | query: &PathQuery, ... | 236 | | grove_version: &GroveVersion, 237 | | ) -> Result<CryptoHash, Error> | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/operations/proof/generate.rs#L215
warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/operations/proof/generate.rs:215:74 | 215 | self.open_transactional_merk_at_path(path.as_slice().into(), &tx, None, grove_version) | ^^^ help: change this to: `tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this function has too many arguments (8/7): grovedb/src/operations/insert/mod.rs#L169
warning: this function has too many arguments (8/7) --> grovedb/src/operations/insert/mod.rs:169:5 | 169 | / fn add_element_on_transaction<'db, B: AsRef<[u8]>>( 170 | | &'db self, 171 | | path: SubtreePath<B>, 172 | | key: &[u8], ... | 177 | | grove_version: &GroveVersion, 178 | | ) -> CostResult<Merk<PrefixedRocksDbTransactionContext<'db>>, Error> { | |________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/operations/insert/mod.rs#L113
warning: this function has too many arguments (8/7) --> grovedb/src/operations/insert/mod.rs:113:5 | 113 | / fn insert_on_transaction<'db, 'b, B: AsRef<[u8]>>( 114 | | &self, 115 | | path: SubtreePath<'b, B>, 116 | | key: &[u8], ... | 121 | | grove_version: &GroveVersion, 122 | | ) -> CostResult<(), Error> { | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/operations/get/query.rs#L629
warning: this function has too many arguments (8/7) --> grovedb/src/operations/get/query.rs:629:5 | 629 | / pub fn query_raw( 630 | | &self, 631 | | path_query: &PathQuery, 632 | | allow_cache: bool, ... | 637 | | grove_version: &GroveVersion, 638 | | ) -> CostResult<(QueryResultElements, u16), Error> { | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/operations/get/query.rs#L255
warning: this function has too many arguments (8/7) --> grovedb/src/operations/get/query.rs:255:5 | 255 | / pub fn query( 256 | | &self, 257 | | path_query: &PathQuery, 258 | | allow_cache: bool, ... | 263 | | grove_version: &GroveVersion, 264 | | ) -> CostResult<(QueryResultElements, u16), Error> { | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/operations/get/query.rs#L124
warning: this function has too many arguments (8/7) --> grovedb/src/operations/get/query.rs:124:5 | 124 | / pub fn query_many_raw( 125 | | &self, 126 | | path_queries: &[&PathQuery], 127 | | allow_cache: bool, ... | 132 | | grove_version: &GroveVersion, 133 | | ) -> CostResult<QueryResultElements, Error> | |_______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/operations/delete/mod.rs#L595
warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/mod.rs:595:5 | 595 | / fn delete_internal_on_transaction<B: AsRef<[u8]>>( 596 | | &self, 597 | | path: SubtreePath<B>, 598 | | key: &[u8], ... | 610 | | grove_version: &GroveVersion, 611 | | ) -> CostResult<bool, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/operations/delete/mod.rs#L472
warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/mod.rs:472:5 | 472 | / pub fn delete_operation_for_delete_internal<B: AsRef<[u8]>>( 473 | | &self, 474 | | path: SubtreePath<B>, 475 | | key: &[u8], ... | 480 | | grove_version: &GroveVersion, 481 | | ) -> CostResult<Option<QualifiedGroveDbOp>, Error> { | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/operations/delete/worst_case.rs#L113
warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/worst_case.rs:113:5 | 113 | / pub fn worst_case_delete_operation_for_delete<'db, S: Storage<'db>>( 114 | | path: &KeyInfoPath, 115 | | key: &KeyInfo, 116 | | in_parent_tree_type: TreeType, ... | 121 | | grove_version: &GroveVersion, 122 | | ) -> CostResult<QualifiedGroveDbOp, Error> { | |______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/operations/delete/delete_up_tree.rs#L198
warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/delete_up_tree.rs:198:5 | 198 | / pub fn add_delete_operations_for_delete_up_tree_while_empty<B: AsRef<[u8]>>( 199 | | &self, 200 | | path: SubtreePath<B>, 201 | | key: &[u8], ... | 206 | | grove_version: &GroveVersion, 207 | | ) -> CostResult<Option<Vec<QualifiedGroveDbOp>>, Error> { | |___________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/operations/delete/delete_up_tree.rs#L166
warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/delete_up_tree.rs:166:5 | 166 | / pub fn delete_operations_for_delete_up_tree_while_empty<B: AsRef<[u8]>>( 167 | | &self, 168 | | path: SubtreePath<B>, 169 | | key: &[u8], ... | 174 | | grove_version: &GroveVersion, 175 | | ) -> CostResult<Vec<QualifiedGroveDbOp>, Error> { | |___________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/operations/delete/average_case.rs#L138
warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/average_case.rs:138:5 | 138 | / pub fn average_case_delete_operation_for_delete<'db, S: Storage<'db>>( 139 | | path: &KeyInfoPath, 140 | | key: &KeyInfo, 141 | | in_parent_tree_type: TreeType, ... | 146 | | grove_version: &GroveVersion, 147 | | ) -> CostResult<QualifiedGroveDbOp, Error> { | |______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (12/7): grovedb/src/element/query.rs#L717
warning: this function has too many arguments (12/7) --> grovedb/src/element/query.rs:717:5 | 717 | / fn query_item( 718 | | storage: &RocksDbStorage, 719 | | item: &QueryItem, 720 | | results: &mut Vec<QueryResultElement>, ... | 729 | | grove_version: &GroveVersion, 730 | | ) -> CostResult<(), Error> { | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/element/query.rs#L302
warning: this function has too many arguments (8/7) --> grovedb/src/element/query.rs:302:5 | 302 | / pub fn get_query_apply_function( 303 | | storage: &RocksDbStorage, 304 | | path: &[&[u8]], 305 | | sized_query: &SizedQuery, ... | 310 | | grove_version: &GroveVersion, 311 | | ) -> CostResult<(QueryResultElements, u16), Error> { | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/element/insert.rs#L368
warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/element/insert.rs:368:32 | 368 | Self::get_optional(&merk, &key, true, grove_version) | ^^^^^ help: change this to: `merk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/debugger.rs#L346
warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/debugger.rs:346:29 | 346 | ... &tx, | ^^^ help: change this to: `tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the following explicit lifetimes could be elided: 'db, 'c: grovedb/src/bidirectional_references.rs#L634
warning: the following explicit lifetimes could be elided: 'db, 'c --> grovedb/src/bidirectional_references.rs:634:28 | 634 | fn get_backward_references<'db, 'c>( | ^^^ ^^ 635 | merk: &mut MerkHandle<'db, 'c>, | ^^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 634 ~ fn get_backward_references( 635 ~ merk: &mut MerkHandle<'_, '_>, |
the following explicit lifetimes could be elided: 'db, 'c: grovedb/src/bidirectional_references.rs#L593
warning: the following explicit lifetimes could be elided: 'db, 'c --> grovedb/src/bidirectional_references.rs:593:27 | 593 | fn add_backward_reference<'db, 'c>( | ^^^ ^^ 594 | target_merk: &mut MerkHandle<'db, 'c>, | ^^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 593 ~ fn add_backward_reference( 594 ~ target_merk: &mut MerkHandle<'_, '_>, |
the following explicit lifetimes could be elided: 'db, 'c: grovedb/src/bidirectional_references.rs#L554
warning: the following explicit lifetimes could be elided: 'db, 'c --> grovedb/src/bidirectional_references.rs:554:35 | 554 | fn get_backward_references_bitvec<'db, 'c>( | ^^^ ^^ 555 | merk: &mut MerkHandle<'db, 'c>, | ^^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 554 ~ fn get_backward_references_bitvec( 555 ~ merk: &mut MerkHandle<'_, '_>, |
this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/bidirectional_references.rs#L348
warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/bidirectional_references.rs:348:75 | 348 | cost_return_on_error!(&mut cost, delta.new.value_hash(&merk_cache.version)) | ^^^^^^^^^^^^^^^^^^^ help: change this to: `merk_cache.version` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/bidirectional_references.rs#L312
warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/bidirectional_references.rs:312:75 | 312 | cost_return_on_error!(&mut cost, delta.new.value_hash(&merk_cache.version)) | ^^^^^^^^^^^^^^^^^^^ help: change this to: `merk_cache.version` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/bidirectional_references.rs#L221
warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/bidirectional_references.rs:221:17 | 221 | &merk_cache.version, | ^^^^^^^^^^^^^^^^^^^ help: change this to: `merk_cache.version` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this lifetime isn't used in the function definition: grovedb/src/bidirectional_references.rs#L114
warning: this lifetime isn't used in the function definition --> grovedb/src/bidirectional_references.rs:114:66 | 114 | pub(crate) fn process_bidirectional_reference_insertion<'db, 'b, 'k, B: AsRef<[u8]>>( | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
the following explicit lifetimes could be elided: 'db: grovedb/src/bidirectional_references.rs#L114
warning: the following explicit lifetimes could be elided: 'db --> grovedb/src/bidirectional_references.rs:114:57 | 114 | pub(crate) fn process_bidirectional_reference_insertion<'db, 'b, 'k, B: AsRef<[u8]>>( | ^^^ 115 | merk_cache: &MerkCache<'db, 'b, B>, | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 114 ~ pub(crate) fn process_bidirectional_reference_insertion<'b, 'k, B: AsRef<[u8]>>( 115 ~ merk_cache: &MerkCache<'_, 'b, B>, |
this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/bidirectional_references.rs#L84
warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/bidirectional_references.rs:84:57 | 84 | get_backward_references_bitvec(target_merk, &target_key) | ^^^^^^^^^^^ help: change this to: `target_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
the following explicit lifetimes could be elided: 'db, 'c: grovedb/src/bidirectional_references.rs#L75
warning: the following explicit lifetimes could be elided: 'db, 'c --> grovedb/src/bidirectional_references.rs:75:43 | 75 | fn remove_backward_reference_resolved<'db, 'c>( | ^^^ ^^ 76 | target_merk: &mut MerkHandle<'db, 'c>, | ^^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 75 ~ fn remove_backward_reference_resolved( 76 ~ target_merk: &mut MerkHandle<'_, '_>, |
the following explicit lifetimes could be elided: 'c, 'db: grovedb/src/bidirectional_references.rs#L41
warning: the following explicit lifetimes could be elided: 'c, 'db --> grovedb/src/bidirectional_references.rs:41:34 | 41 | fn remove_backward_reference<'db, 'b, 'c, B: AsRef<[u8]>>( | ^^^ ^^ 42 | self, 43 | merk_cache: &'c MerkCache<'db, 'b, B>, | ^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 41 ~ fn remove_backward_reference<'b, B: AsRef<[u8]>>( 42 | self, 43 ~ merk_cache: &MerkCache<'_, 'b, B>, |
this function has too many arguments (8/7): grovedb/src/batch/mod.rs#L2426
warning: this function has too many arguments (8/7) --> grovedb/src/batch/mod.rs:2426:5 | 2426 | / pub fn apply_partial_batch_with_element_flags_update( 2427 | | &self, 2428 | | ops: Vec<QualifiedGroveDbOp>, 2429 | | batch_apply_options: Option<BatchApplyOptions>, ... | 2448 | | grove_version: &GroveVersion, 2449 | | ) -> CostResult<(), Error> { | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/batch/mod.rs#L2055
warning: this function has too many arguments (8/7) --> grovedb/src/batch/mod.rs:2055:5 | 2055 | / fn continue_partial_apply_body<'db, S: StorageContext<'db>>( 2056 | | &self, 2057 | | previous_leftover_operations: Option<OpsByLevelPath>, 2058 | | additional_ops: Vec<QualifiedGroveDbOp>, ... | 2074 | | grove_version: &GroveVersion, 2075 | | ) -> CostResult<Option<OpsByLevelPath>, Error> { | |__________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (9/7): grovedb/src/batch/mod.rs#L961
warning: this function has too many arguments (9/7) --> grovedb/src/batch/mod.rs:961:5 | 961 | / fn process_reference_with_hop_count_greater_than_one<'a, G, SR>( 962 | | &'a mut self, 963 | | key: &[u8], 964 | | reference_path: &[Vec<u8>], ... | 970 | | grove_version: &GroveVersion, 971 | | ) -> CostResult<CryptoHash, Error> | |______________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/batch/mod.rs#L743
warning: this function has too many arguments (8/7) --> grovedb/src/batch/mod.rs:743:5 | 743 | / fn process_reference<'a, G, SR>( 744 | | &'a mut self, 745 | | qualified_path: &[Vec<u8>], 746 | | ops_by_qualified_paths: &'a BTreeMap<Vec<Vec<u8>>, GroveOp>, ... | 751 | | grove_version: &GroveVersion, 752 | | ) -> CostResult<CryptoHash, Error> | |______________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): grovedb/src/batch/mod.rs#L680
warning: this function has too many arguments (8/7) --> grovedb/src/batch/mod.rs:680:5 | 680 | / fn execute_ops_on_path( 681 | | &mut self, 682 | | path: &KeyInfoPath, 683 | | ops_at_path_by_key: BTreeMap<KeyInfo, GroveOp>, ... | 688 | | grove_version: &GroveVersion, 689 | | ) -> CostResult<RootHashKeyAndAggregateData, Error>; | |_______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (9/7): grovedb/src/batch/just_in_time_reference_update.rs#L29
warning: this function has too many arguments (9/7) --> grovedb/src/batch/just_in_time_reference_update.rs:29:5 | 29 | / pub(crate) fn process_old_element_flags<G, SR>( 30 | | key: &[u8], 31 | | serialized: &[u8], 32 | | new_element: &mut Element, ... | 38 | | grove_version: &GroveVersion, 39 | | ) -> CostResult<CryptoHash, Error> | |______________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
function `follow_reference_once` is never used: grovedb/src/reference_path.rs#L637
warning: function `follow_reference_once` is never used --> grovedb/src/reference_path.rs:637:15 | 637 | pub(crate) fn follow_reference_once<'db, 'b, 'c, B: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^^^^^^
function `follow_reference` is never used: grovedb/src/reference_path.rs#L550
warning: function `follow_reference` is never used --> grovedb/src/reference_path.rs:550:15 | 550 | pub(crate) fn follow_reference<'db, 'b, 'c, B: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^
struct `ResolvedReference` is never constructed: grovedb/src/reference_path.rs#L541
warning: struct `ResolvedReference` is never constructed --> grovedb/src/reference_path.rs:541:19 | 541 | pub(crate) struct ResolvedReference<'db, 'b, 'c, B> { | ^^^^^^^^^^^^^^^^^
method `invert` is never used: grovedb/src/reference_path.rs#L76
warning: method `invert` is never used --> grovedb/src/reference_path.rs:76:19 | 74 | impl ReferencePathType { | ---------------------- method in this implementation 75 | /// Get an inverted reference 76 | pub(crate) fn invert<B: AsRef<[u8]>>(&self, path: SubtreePath<B>, key: &[u8]) -> Option<Self> { | ^^^^^^
method `for_merk` is never used: grovedb/src/merk_cache.rs#L180
warning: method `for_merk` is never used --> grovedb/src/merk_cache.rs:180:19 | 179 | impl<'db> MerkHandle<'db, '_> { | ----------------------------- method in this implementation 180 | pub(crate) fn for_merk<T>(&mut self, f: impl FnOnce(&mut TxMerk<'db>) -> T) -> T { | ^^^^^^^^
struct `MerkHandle` is never constructed: grovedb/src/merk_cache.rs#L174
warning: struct `MerkHandle` is never constructed --> grovedb/src/merk_cache.rs:174:19 | 174 | pub(crate) struct MerkHandle<'db, 'c> { | ^^^^^^^^^^
struct `MerkCache` is never constructed: grovedb/src/merk_cache.rs#L23
warning: struct `MerkCache` is never constructed --> grovedb/src/merk_cache.rs:23:19 | 23 | pub(crate) struct MerkCache<'db, 'b, B: AsRef<[u8]>> { | ^^^^^^^^^
type alias `CachedMerkEntry` is never used: grovedb/src/merk_cache.rs#L20
warning: type alias `CachedMerkEntry` is never used --> grovedb/src/merk_cache.rs:20:6 | 20 | type CachedMerkEntry<'db> = Box<(Cell<bool>, TxMerk<'db>)>; | ^^^^^^^^^^^^^^^
type alias `TxMerk` is never used: grovedb/src/merk_cache.rs#L16
warning: type alias `TxMerk` is never used --> grovedb/src/merk_cache.rs:16:6 | 16 | type TxMerk<'db> = Merk<PrefixedRocksDbTransactionContext<'db>>; | ^^^^^^
function `get_backward_references` is never used: grovedb/src/bidirectional_references.rs#L634
warning: function `get_backward_references` is never used --> grovedb/src/bidirectional_references.rs:634:4 | 634 | fn get_backward_references<'db, 'c>( | ^^^^^^^^^^^^^^^^^^^^^^^
function `add_backward_reference` is never used: grovedb/src/bidirectional_references.rs#L593
warning: function `add_backward_reference` is never used --> grovedb/src/bidirectional_references.rs:593:4 | 593 | fn add_backward_reference<'db, 'c>( | ^^^^^^^^^^^^^^^^^^^^^^
function `get_backward_references_bitvec` is never used: grovedb/src/bidirectional_references.rs#L554
warning: function `get_backward_references_bitvec` is never used --> grovedb/src/bidirectional_references.rs:554:4 | 554 | fn get_backward_references_bitvec<'db, 'c>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
function `make_meta_prefix` is never used: grovedb/src/bidirectional_references.rs#L542
warning: function `make_meta_prefix` is never used --> grovedb/src/bidirectional_references.rs:542:4 | 542 | fn make_meta_prefix(key: &[u8]) -> Vec<u8> { | ^^^^^^^^^^^^^^^^
type alias `Prefix` is never used: grovedb/src/bidirectional_references.rs#L540
warning: type alias `Prefix` is never used --> grovedb/src/bidirectional_references.rs:540:6 | 540 | type Prefix = Vec<u8>; | ^^^^^^
associated items `serialize` and `deserialize` are never used: grovedb/src/bidirectional_references.rs#L525
warning: associated items `serialize` and `deserialize` are never used --> grovedb/src/bidirectional_references.rs:525:8 | 524 | impl BackwardReference { | ---------------------- associated items in this implementation 525 | fn serialize(&self) -> Result<Vec<u8>, Error> { | ^^^^^^^^^ ... 532 | fn deserialize(bytes: &[u8]) -> Result<BackwardReference, Error> { | ^^^^^^^^^^^
function `propagate_backward_references` is never used: grovedb/src/bidirectional_references.rs#L464
warning: function `propagate_backward_references` is never used --> grovedb/src/bidirectional_references.rs:464:4 | 464 | fn propagate_backward_references<'db, 'b, 'c, B: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
function `delete_backward_references_recursively` is never used: grovedb/src/bidirectional_references.rs#L390
warning: function `delete_backward_references_recursively` is never used --> grovedb/src/bidirectional_references.rs:390:4 | 390 | fn delete_backward_references_recursively<'db, 'b, 'c, B: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
function `process_update_element_with_backward_references` is never used: grovedb/src/bidirectional_references.rs#L279
warning: function `process_update_element_with_backward_references` is never used --> grovedb/src/bidirectional_references.rs:279:15 | 279 | pub(crate) fn process_update_element_with_backward_references<'db, 'b, 'c, B: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
function `process_bidirectional_reference_insertion` is never used: grovedb/src/bidirectional_references.rs#L114
warning: function `process_bidirectional_reference_insertion` is never used --> grovedb/src/bidirectional_references.rs:114:15 | 114 | pub(crate) fn process_bidirectional_reference_insertion<'db, 'b, 'k, B: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
associated items `remove_backward_reference` and `remove_backward_reference_resolved` are never used: grovedb/src/bidirectional_references.rs#L41
warning: associated items `remove_backward_reference` and `remove_backward_reference_resolved` are never used --> grovedb/src/bidirectional_references.rs:41:8 | 38 | impl BidirectionalReference { | --------------------------- associated items in this implementation ... 41 | fn remove_backward_reference<'db, 'b, 'c, B: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^^^^^^^^^^ ... 75 | fn remove_backward_reference_resolved<'db, 'c>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
constant `META_BACKWARD_REFERENCES_PREFIX` is never used: grovedb/src/bidirectional_references.rs#L19
warning: constant `META_BACKWARD_REFERENCES_PREFIX` is never used --> grovedb/src/bidirectional_references.rs:19:7 | 19 | const META_BACKWARD_REFERENCES_PREFIX: &'static [u8] = b"refs"; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
variants `Execute`, `AverageCase`, and `WorstCase` are never constructed: grovedb/src/batch/mode.rs#L18
warning: variants `Execute`, `AverageCase`, and `WorstCase` are never constructed --> grovedb/src/batch/mode.rs:18:5 | 17 | pub enum BatchRunMode { | ------------ variants in this enum 18 | Execute, | ^^^^^^^ 19 | #[cfg(feature = "estimated_costs")] 20 | AverageCase(HashMap<KeyInfoPath, EstimatedLayerInformation>), | ^^^^^^^^^^^ 21 | #[cfg(feature = "estimated_costs")] 22 | WorstCase(HashMap<KeyInfoPath, WorstCaseLayerInformation>), | ^^^^^^^^^ | = note: `BatchRunMode` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
method `get_batch_run_mode` is never used: grovedb/src/batch/mod.rs#L677
warning: method `get_batch_run_mode` is never used --> grovedb/src/batch/mod.rs:677:8 | 674 | trait TreeCache<G, SR> { | --------- method in this trait ... 677 | fn get_batch_run_mode(&self) -> BatchRunMode; | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
unexpected `cfg` condition value: `test_utils`: grovedb/src/element/insert.rs#L549
warning: unexpected `cfg` condition value: `test_utils` --> grovedb/src/element/insert.rs:549:32 | 549 | #[cfg(all(feature = "minimal", feature = "test_utils"))] | ^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `axum`, `bitvec`, `default`, `estimated_costs`, `full`, `grovedb-costs`, `grovedb-merk`, `grovedb-storage`, `grovedb-visualize`, `grovedbg`, `grovedbg-types`, `integer-encoding`, `intmap`, `itertools`, `minimal`, `proof_debug`, `serde`, `tempfile`, `thiserror`, `tokio`, `tokio-util`, `tower-http`, `verify`, `visualize`, and `zip-extensions` = help: consider adding `test_utils` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default
constants have by default a `'static` lifetime: grovedb/src/bidirectional_references.rs#L19
warning: constants have by default a `'static` lifetime --> grovedb/src/bidirectional_references.rs:19:41 | 19 | const META_BACKWARD_REFERENCES_PREFIX: &'static [u8] = b"refs"; | -^^^^^^^----- help: consider removing `'static`: `&[u8]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
this function has too many arguments (9/7): merk/src/tree/mod.rs#L943
warning: this function has too many arguments (9/7) --> merk/src/tree/mod.rs:943:5 | 943 | / pub fn put_value_with_reference_value_hash_and_value_cost( 944 | | mut self, 945 | | value: Vec<u8>, 946 | | value_hash: CryptoHash, ... | 969 | | >, 970 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): merk/src/tree/mod.rs#L885
warning: this function has too many arguments (8/7) --> merk/src/tree/mod.rs:885:5 | 885 | / pub fn put_value_and_reference_value_hash( 886 | | mut self, 887 | | value: Vec<u8>, 888 | | value_hash: CryptoHash, ... | 910 | | >, 911 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): merk/src/tree/mod.rs#L829
warning: this function has too many arguments (8/7) --> merk/src/tree/mod.rs:829:5 | 829 | / pub fn put_value_with_fixed_cost( 830 | | mut self, 831 | | value: Vec<u8>, 832 | | value_fixed_cost: u32, ... | 854 | | >, 855 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (9/7): merk/src/tree/walk/mod.rs#L341
warning: this function has too many arguments (9/7) --> merk/src/tree/walk/mod.rs:341:5 | 341 | / pub fn put_value_with_reference_value_hash_and_value_cost( 342 | | mut self, 343 | | value: Vec<u8>, 344 | | value_hash: CryptoHash, ... | 367 | | >, 368 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): merk/src/tree/walk/mod.rs#L295
warning: this function has too many arguments (8/7) --> merk/src/tree/walk/mod.rs:295:5 | 295 | / pub fn put_value_and_reference_value_hash( 296 | | mut self, 297 | | value: Vec<u8>, 298 | | value_hash: CryptoHash, ... | 320 | | >, 321 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): merk/src/tree/walk/mod.rs#L249
warning: this function has too many arguments (8/7) --> merk/src/tree/walk/mod.rs:249:5 | 249 | / pub fn put_value_with_fixed_cost( 250 | | mut self, 251 | | value: Vec<u8>, 252 | | value_fixed_cost: u32, ... | 274 | | >, 275 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (11/7): merk/src/tree/ops.rs#L733
warning: this function has too many arguments (11/7) --> merk/src/tree/ops.rs:733:5 | 733 | / fn recurse<K: AsRef<[u8]>, C, V, T, U, R>( 734 | | self, 735 | | batch: &MerkBatch<K>, 736 | | mid: usize, ... | 744 | | grove_version: &GroveVersion, 745 | | ) -> CostResult<(Option<Self>, KeyUpdates), Error> | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): merk/src/tree/ops.rs#L415
warning: this function has too many arguments (8/7) --> merk/src/tree/ops.rs:415:5 | 415 | / fn apply_sorted<K: AsRef<[u8]>, C, V, T, U, R>( 416 | | self, 417 | | batch: &MerkBatch<K>, 418 | | old_specialized_cost: &C, ... | 423 | | grove_version: &GroveVersion, 424 | | ) -> CostResult<(Option<Self>, KeyUpdates), Error> | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): merk/src/tree/ops.rs#L235
warning: this function has too many arguments (8/7) --> merk/src/tree/ops.rs:235:5 | 235 | / fn build<K: AsRef<[u8]>, C, V, T, U, R>( 236 | | batch: &MerkBatch<K>, 237 | | source: S, 238 | | old_tree_cost: &C, ... | 243 | | grove_version: &GroveVersion, 244 | | ) -> CostResult<Option<TreeNode>, Error> | |____________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (9/7): merk/src/tree/ops.rs#L148
warning: this function has too many arguments (9/7) --> merk/src/tree/ops.rs:148:5 | 148 | / pub fn apply_to<K: AsRef<[u8]>, C, V, T, U, R>( 149 | | maybe_tree: Option<Self>, 150 | | batch: &MerkBatch<K>, 151 | | source: S, ... | 157 | | grove_version: &GroveVersion, 158 | | ) -> CostContext<Result<(Option<TreeNode>, KeyUpdates), Error>> | |___________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
module has the same name as its containing module: merk/src/proofs/chunk.rs#L5
warning: module has the same name as its containing module --> merk/src/proofs/chunk.rs:5:1 | 5 | pub mod chunk; | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default
this function has too many arguments (8/7): merk/src/merk/mod.rs#L694
warning: this function has too many arguments (8/7) --> merk/src/merk/mod.rs:694:5 | 694 | / fn verify_link( 695 | | &self, 696 | | link: &Link, 697 | | parent_key: &[u8], ... | 702 | | grove_version: &GroveVersion, 703 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
very complex type used. Consider factoring parts into `type` definitions: merk/src/merk/mod.rs#L634
warning: very complex type used. Consider factoring parts into `type` definitions --> merk/src/merk/mod.rs:634:10 | 634 | ) -> (BTreeMap<Vec<u8>, CryptoHash>, BTreeMap<Vec<u8>, Vec<u8>>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
this function has too many arguments (10/7): merk/src/merk/apply.rs#L322
warning: this function has too many arguments (10/7) --> merk/src/merk/apply.rs:322:5 | 322 | / pub fn apply_unchecked<KB, KA, C, V, T, U, R>( 323 | | &mut self, 324 | | batch: &MerkBatch<KB>, 325 | | aux: &AuxMerkBatch<KA>, ... | 332 | | grove_version: &GroveVersion, 333 | | ) -> CostResult<(), Error> | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (10/7): merk/src/merk/apply.rs#L206
warning: this function has too many arguments (10/7) --> merk/src/merk/apply.rs:206:5 | 206 | / pub fn apply_with_costs_just_in_time_value_update<KB, KA>( 207 | | &mut self, 208 | | batch: &MerkBatch<KB>, 209 | | aux: &AuxMerkBatch<KA>, ... | 235 | | grove_version: &GroveVersion, 236 | | ) -> CostResult<(), Error> | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
very complex type used. Consider factoring parts into `type` definitions: merk/src/merk/chunks.rs#L393
warning: very complex type used. Consider factoring parts into `type` definitions --> merk/src/merk/chunks.rs:393:10 | 393 | ) -> Option<Result<(Vec<Op>, Option<Vec<u8>>), Error>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: merk/src/merk/chunks.rs#L363
warning: very complex type used. Consider factoring parts into `type` definitions --> merk/src/merk/chunks.rs:363:10 | 363 | ) -> Option<Result<(Vec<Op>, Option<Vec<u8>>), Error>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
method `apply_sorted_without_costs` is never used: merk/src/tree/ops.rs#L390
warning: method `apply_sorted_without_costs` is never used --> merk/src/tree/ops.rs:390:19 | 139 | / impl<S> Walker<S> 140 | | where 141 | | S: Fetch + Sized + Clone, | |_____________________________- method in this implementation ... 390 | pub(crate) fn apply_sorted_without_costs<K: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^
method `attempt_state_recovery` is never used: merk/src/merk/restore.rs#L418
warning: method `attempt_state_recovery` is never used --> merk/src/merk/restore.rs:418:8 | 68 | impl<'db, S: StorageContext<'db>> Restorer<S> { | --------------------------------------------- method in this implementation ... 418 | fn attempt_state_recovery(&mut self, grove_version: &GroveVersion) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
unexpected `cfg` condition name: `tests`: merk/src/tree/fuzz_tests.rs#L3
warning: unexpected `cfg` condition name: `tests` --> merk/src/tree/fuzz_tests.rs:3:8 | 3 | #![cfg(tests)] | ^^^^^ help: there is a config with a similar name: `test` | = help: consider using a Cargo feature instead = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tests)'] } = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tests)");` to the top of the `build.rs` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default
Code Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636