feat(sdk): asset lock quorum and core locked height verification #5379
Annotations
10 warnings and 1 notice
Run clechasseur/rs-clippy-check@v3:
packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/v1/v0_methods.rs#L30
warning: unused imports: `TokenBurnTransition`, `TokenConfigUpdateTransition`, `TokenDestroyFrozenFundsTransition`, `TokenEmergencyActionTransition`, `TokenFreezeTransition`, `TokenMintTransition`, `TokenTransferTransition`, and `TokenUnfreezeTransition`
--> packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/v1/v0_methods.rs:30:68
|
30 | ...1, TokenBurnTransition, TokenConfigUpdateTransition, TokenDestroyFrozenFundsTransition, TokenEmergencyActionTransition, TokenFreezeTransition, TokenMintTransition, TokenTransferTransition, TokenUnfreezeTransitio...
| ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive/src/drive/document/query/mod.rs#L24
warning: duplicated attribute
--> packages/rs-drive/src/drive/document/query/mod.rs:24:7
|
24 | #[cfg(feature = "fixtures-and-mocks")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first defined here
--> packages/rs-drive/src/drive/document/query/mod.rs:23:7
|
23 | #[cfg(feature = "fixtures-and-mocks")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: remove this attribute
--> packages/rs-drive/src/drive/document/query/mod.rs:24:7
|
24 | #[cfg(feature = "fixtures-and-mocks")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes
= note: `#[warn(clippy::duplicated_attributes)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive/src/drive/document/query/mod.rs#L49
warning: empty line after doc comment
--> packages/rs-drive/src/drive/document/query/mod.rs:49:1
|
49 | / /// The outcome of a query
... |
58 | |
| |_^
...
62 | pub struct QuerySerializedDocumentsOutcome {
| ------------------------------------------ the comment documents this struct
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
help: if the doc comment should not document `QuerySerializedDocumentsOutcome` comment it out
|
49 | // /// The outcome of a query
| ++
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive/src/drive/document/query/mod.rs#L74
warning: empty line after doc comment
--> packages/rs-drive/src/drive/document/query/mod.rs:74:5
|
74 | / /// along with skipped items and the cost.
... |
111 | |
| |_^
...
114 | / pub fn query_raw_documents_from_contract_cbor_using_cbor_encoded_query_with_cost(
115 | | &self,
116 | | query_cbor: &[u8],
117 | | contract: &DataContract,
... |
121 | | protocol_version: Option<u32>,
122 | | ) -> Result<(Vec<Vec<u8>>, u16, u64), Error> {
| |________________________________________________- the comment documents this method
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
help: if the doc comment should not document `query_raw_documents_from_contract_cbor_using_cbor_encoded_query_with_cost` comment it out
|
73 ~ // /// Performs and returns the result as ids of the specified query
74 ~ // /// along with skipped items and the cost.
|
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive/src/query/mod.rs#L1335
warning: this `else { if .. }` block can be collapsed
--> packages/rs-drive/src/query/mod.rs:1335:16
|
1335 | } else {
| ________________^
1336 | | if let Some(start_at_key) = start_at_key {
1337 | | inner_query.insert_range_to(..start_at_key);
1338 | | } else {
... |
1343 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
1335 ~ } else if let Some(start_at_key) = start_at_key {
1336 + inner_query.insert_range_to(..start_at_key);
1337 + } else {
1338 + //todo: really not sure if this is correct
1339 + // Should investigate more
1340 + inner_query.insert_key(vec![]);
1341 + }
|
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive/src/verify/tokens/verify_token_pre_programmed_distributions/v0/mod.rs#L83
warning: this pattern is unneeded as the `..` pattern can match that element
--> packages/rs-drive/src/verify/tokens/verify_token_pre_programmed_distributions/v0/mod.rs:83:34
|
83 | Some(SumItem(_, ..)) => {
| ^^^ help: remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_wildcard_pattern
= note: `#[warn(clippy::unneeded_wildcard_pattern)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive/src/verify/tokens/verify_token_pre_programmed_distributions/v0/mod.rs#L97
warning: use of `or_insert_with` to construct default value
--> packages/rs-drive/src/verify/tokens/verify_token_pre_programmed_distributions/v0/mod.rs:97:22
|
97 | .or_insert_with(Vec::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `#[warn(clippy::unwrap_or_default)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive/src/drive/group/fetch/fetch_action_id_has_signer/mod.rs#L83
warning: method `fetch_action_id_has_signer_and_add_operations` is never used
--> packages/rs-drive/src/drive/group/fetch/fetch_action_id_has_signer/mod.rs:83:19
|
14 | impl Drive {
| ---------- method in this implementation
...
83 | pub(crate) fn fetch_action_id_has_signer_and_add_operations(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive/src/drive/group/fetch/fetch_action_id_has_signer/mod.rs#L47
warning: empty line after doc comment
--> packages/rs-drive/src/drive/group/fetch/fetch_action_id_has_signer/mod.rs:47:5
|
47 | / /// Fetches if an identity has already signed in an action with costs
48 | |
| |_^
49 | / pub fn fetch_action_id_has_signer_with_costs(
50 | | &self,
51 | | contract_id: Identifier,
52 | | group_contract_position: GroupContractPosition,
... |
57 | | platform_version: &PlatformVersion,
58 | | ) -> Result<(bool, FeeResult), Error> {
| |_________________________________________- the comment documents this method
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive/src/drive/group/fetch/fetch_action_id_info_keep_serialized/mod.rs#L85
warning: method `fetch_action_id_info_keep_serialized_and_add_operations` is never used
--> packages/rs-drive/src/drive/group/fetch/fetch_action_id_info_keep_serialized/mod.rs:85:19
|
14 | impl Drive {
| ---------- method in this implementation
...
85 | pub(crate) fn fetch_action_id_info_keep_serialized_and_add_operations(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
Post Setup sccache
100% - 454 hits, 0 misses, 0 errors
|
Loading