Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update links to correct URLs in package.json #2068

Open
wants to merge 412 commits into
base: master
Choose a base branch
from

Conversation

Validark
Copy link

@Validark Validark commented Aug 22, 2024

Updated the package.json files to reflect the move to the monorepo.
Note: I did not update the versions of the package.json files. I presume that would happen immediately before pushing to npm?

Issue being fixed or feature implemented

Helps npm point to the right location

What was done?

Updated links in the package.json files. In each package.json file:

How Has This Been Tested?

n/a

Breaking Changes

none

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

pauldelucia and others added 30 commits April 29, 2024 22:39
shumkov and others added 22 commits August 13, 2024 16:15
@Validark
Copy link
Author

Are the homepages supposed to point to the v1.1-dev branch? Not really sure what to do about that.

@lklimek
Copy link
Contributor

lklimek commented Aug 23, 2024

Are the homepages supposed to point to the v1.1-dev branch? Not really sure what to do about that.

Maybe HEAD, for example https://github.com/dashpay/platform/tree/HEAD/packages/dashpay-contract#readme ?

},
"homepage": "https://github.com/dashevo/dapi-grpc#readme",
"homepage": "https://github.com/dashpay/platform/tree/v1.1-dev/packages/dapi-grpc#readme",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use master. v1.1-dev will be deleted at some point.

@shumkov shumkov changed the title fix(package.json): update links to correct URLs for "homepage", "repository.url", "bugs.url" chore: update links to correct URLs in package.json Aug 24, 2024
@shumkov shumkov changed the base branch from v1.1-dev to master August 25, 2024 07:39
@shumkov shumkov requested a review from antouhou as a code owner August 25, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants