-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build!: optimize build process for Haswell CPUs #2374
base: v1.7-dev
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Issue being fixed or feature implemented
In v1.6.2, we reverted change introducing CPU performance optimizations for x86-64 architecture.
We want these optimizations to be enabled in final release image.
We will still keep unoptimized code in debug images (the ones with
-debug
suffix) as a fallback mechanism.What was done?
Enabled CPU optimizations for release images in:
How Has This Been Tested?
Inspected using https://github.com/pkgw/elfx86exts/
Debug:
42 10.22 Instruction set extensions used: ADX, AES, AVX, AVX2, AVX512, BMI, BMI2, CMOV, MODE64, NOVLX, PCLMUL, SHA, SSE1, SSE2, SSE3, SSE41, SSSE3, VLX
Release:
42 4.391 Instruction set extensions used: ADX, AES, AVX, AVX2, AVX512, BMI, BMI2, CMOV, MODE64, NOVLX, PCLMUL, SHA, SSE1, SSE2, SSE41, SSE42, SSSE3, VLX
Breaking Changes
Dash Platform nodes must have Haswell instruction set, including: 64-bit extensions, MMX, SSE, SSE2, SSE3, SSSE3, SSE4.1, SSE4.2, POPCNT, CX16, SAHF, FXSR, AVX, XSAVE, PCLMUL, FSGSBASE, RDRND, F16C, AVX2, BMI, BMI2, LZCNT, FMA, MOVBE and HLE.
Checklist:
For repository code-owners and collaborators only