fix(consensus): PrepareProposal should not be called during replay (#678

)

internal/consensus/state_controller.go

@@ -87,6 +87,7 @@ func NewController(cs *State, wal *wrapWAL, statsQueue *chanQueue[msgInfo], prop
 			scheduler:       cs.roundScheduler,
 			eventPublisher:  cs.eventPublisher,
 			proposalCreator: propler,
+			replayMode:      cs.replayMode,
 		},
 		AddProposalBlockPartType: &AddProposalBlockPartAction{
 			logger:         cs.logger,

internal/consensus/state_enter_propose.go

@@ -31,6 +31,7 @@ type EnterProposeAction struct {
 	scheduler       *roundScheduler
 	eventPublisher  *EventPublisher
 	proposalCreator cstypes.ProposalCreator
+	replayMode      bool
 }
 
 func (c *EnterProposeAction) Execute(ctx context.Context, stateEvent StateEvent) error {
@@ -93,6 +94,12 @@ func (c *EnterProposeAction) Execute(ctx context.Context, stateEvent StateEvent)
 			"node_proTxHash", proTxHash.String())
 		return nil
 	}
+	// In replay mode, we don't propose blocks.
+	if c.replayMode {
+		logger.Debug("enter propose step; our turn to propose but in replay mode, not proposing")
+		return nil
+	}
+
 	logger.Debug("propose step; our turn to propose",
 		"proposer_proTxHash", proTxHash.ShortString(),
 	)

internal/consensus/types/round_state.go

@@ -97,7 +97,7 @@ type RoundState struct {
 	// Last known round with POL for non-nil valid block.
 	ValidRound         int32        `json:"valid_round"`
 	ValidBlock         *types.Block `json:"valid_block"`      // Last known block of POL mentioned above.
-	ValidBlockRecvTime time.Time    `json:"valid_block_time"` // Receive time of ast known block of POL mentioned above.
+	ValidBlockRecvTime time.Time    `json:"valid_block_time"` // Receive time of last known block of POL mentioned above.
 
 	// Last known block parts of POL mentioned above.
 	ValidBlockParts           *types.PartSet      `json:"valid_block_parts"`