Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(consensus): improve logs #679

Merged
merged 2 commits into from
Sep 13, 2023
Merged

chore(consensus): improve logs #679

merged 2 commits into from
Sep 13, 2023

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Sep 12, 2023

Issue being fixed or feature implemented

Tenderdash generates too many logs in Debug level.

What was done?

Modified log level for some commonly used logs:

  1. Logs that show normal operation (primary execution path) of system are at Trace level
  2. Important logs that add significant value are at Debug level
  3. Logs that show error conditions are on Error level
  4. Logs intended to the user (MNO/sysops) are Info or Error

How Has This Been Tested?

Github Actions

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

shumkov
shumkov previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek enabled auto-merge (squash) September 13, 2023 08:38
@lklimek lklimek merged commit 5edf552 into v0.13-dev Sep 13, 2023
13 checks passed
@lklimek lklimek deleted the improve-logs branch September 13, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

@shotonoff shotonoff Awaiting requested review from shotonoff shotonoff is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lklimek @shumkov