Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: log-file-path setting does not work (#691) #693

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Oct 9, 2023

Issue being fixed or feature implemented

Backport #691 into v0.13

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

* fix: log-file-path setting does not work

* chore: remove one-liner func

* refactor: simplify a bit
@lklimek lklimek enabled auto-merge (rebase) October 9, 2023 08:54
@lklimek lklimek merged commit 57fa229 into v0.13-dev Oct 9, 2023
15 checks passed
@lklimek lklimek deleted the backport-691-to-13 branch February 1, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants