Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(abci): proposer-based app version #769

Merged
merged 13 commits into from
Mar 27, 2024
Merged

feat(abci): proposer-based app version #769

merged 13 commits into from
Mar 27, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Mar 20, 2024

Issue being fixed or feature implemented

Proposer, during CreateProposal, can propose app version to be included in the current block, replacing the one determined based on consensus params.

What was done?

  • added field ResponsePrepareProposal.app_version
  • implemented relevant logic

How Has This Been Tested?

  • added unit test
  • passed e2e tests
  • TODO: test using Drive

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

lklimek added 4 commits March 20, 2024 14:41
@lklimek
feat(abci)!: proposer-based app version
5c4b043 
Proposer, during CreateProposal, can propose app version to be included in the current block, replacing the one determined based on consensus params.
@lklimek
chore: bump abci version requirement
12461e9
@lklimek
test(state): remove invalid tests from header/block validation
a3baef3
@lklimek
doc(proto): minor improvements
cc25fb0
@lklimek lklimek force-pushed the feat/proposer-app-version branch from 81be6d6 to 55c3880 Compare March 20, 2024 15:34
@lklimek lklimek force-pushed the feat/proposer-app-version branch from 55c3880 to 7c99dc8 Compare March 20, 2024 15:48
@lklimek lklimek marked this pull request as ready for review March 20, 2024 15:49
@lklimek lklimek enabled auto-merge (squash) March 20, 2024 16:14
@lklimek lklimek disabled auto-merge March 27, 2024 13:33
shumkov
shumkov requested changes Mar 27, 2024
View reviewed changes
internal/state/validation_test.go Show resolved Hide resolved
proto/tendermint/abci/types.proto Outdated Show resolved Hide resolved
@lklimek lklimek requested a review from shumkov March 27, 2024 15:37
@lklimek lklimek enabled auto-merge (squash) March 27, 2024 15:59
shumkov
shumkov approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 39c275a into v0.14-dev Mar 27, 2024
19 checks passed
@lklimek lklimek deleted the feat/proposer-app-version branch March 27, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lklimek @shumkov