Remove libprotobuf dep #1249
Remove libprotobuf dep #1249
Conversation
jdye64
requested review from
ayushdg,
charlesbluca and
galipremsagar
as code owners
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 85.55% 85.55%
=======================================
Files 77 77
Lines 4257 4257
Branches 758 758
=======================================
Hits 3642 3642
Misses 446 446
Partials 169 169 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
Do not merge until apache/datafusion-python#527 is merged and this PR is updated first. |
…ave but seems to be causing issues
|
rerun tests |
|
@charlesbluca Any chance you could take a look at this today? |
There was a problem hiding this comment.
Thanks for this work @jdye64, this looks good so far. Looks like there's still some bits to the wheel release workflow that need to be modified to remove protoc installation, mind if I push some commits to get that working?
| @@ -6,7 +6,7 @@ channels: | |||
| - nvidia | |||
| - nodefaults | |||
| dependencies: | |||
| - c-compiler | |||
There was a problem hiding this comment.
Based on the conda recipe, seems like we still need a C compiler for compilation - do we need to modify this pinning in some way?
| @@ -15,7 +15,7 @@ dependencies: | |||
| - intake>=0.6.0 | |||
| - jsonschema | |||
| - lightgbm | |||
| - maturin>=1.1,<1.2 | |||
There was a problem hiding this comment.
Just out of interest, what are the specific features we need from the newer version of maturin? Also might make sense to pin this a little more tightly if the specific version we need is 1.3.1:
| - maturin>=1.1,<1.2 | |
| - maturin>=1.3.1,<1.4 |
| @@ -1,4 +1,4 @@ | |||
| rust_compiler_version: | |||
| - 1.69 | |||
| - 1.73 | |||
| maturin: | |||
| - 1.1 | |||
There was a problem hiding this comment.
Should change this to match whatever pinned maturin version we converge on; assuming for now that's 1.3.1:
| - 1.1 | |
| - 1.3.1 |
No description provided.