Drop latest datafusion testing from nightly tests #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
+ Coverage 82.73% 85.52% +2.79%
==========================================
Files 75 77 +2
Lines 4158 4256 +98
Branches 772 794 +22
==========================================
+ Hits 3440 3640 +200
+ Misses 549 447 -102
Partials 169 169 ☔ View full report in Codecov by Sentry. |
|
Agreed, thanks for the cleanup @charlesbluca. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that in practice, the nightly tests against latest DataFusion don't really provide much actionable information, and increases the toil around diagnosing failures coming from latest Dask, which are relatively common.
I've still left the logic for using latest DataFusion in PRs, so we still have a mechanism to it if needed.
cc @ayushdg