Pre-compute window function operands to simplify Dask graph #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the hope is that dask/dask-expr#1059 should unblock (at least some of) the hanging tests, observation of the graphs getting produced from our window code shows that we should be able to simplify things pretty significantly by extracting all the operand columns at once from the base dataframe (which in practice should not be getting modified in any meaningful way by the following groupby-apply operations).
Haven't un-skipped any of the tests because things are still hanging, though now this seems to be getting caused by
fix_dtype_to_row_type- will explore this function to see if there's any patterns we could simplify there.