Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to rust 1.72 in CI #1333

Merged
merged 4 commits into from
May 15, 2024
Merged

Pin to rust 1.72 in CI #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6ce8e9
Bump sysroot_linux-64 to 2.17 in CI
charlesbluca May 13, 2024
66563e6
Easier fix? Pin to rust 1.72 in CI for now
charlesbluca May 13, 2024
c315329
Revert "Bump sysroot_linux-64 to 2.17 in CI"
charlesbluca May 13, 2024
2c7972f
Make sure 1.72 is used by default
charlesbluca May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions-rs/toolchain@v1
with:
toolchain: 1.72
default: true
- name: Cache Cargo
uses: actions/cache@v3
with:
Expand All @@ -63,6 +67,10 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: true
- uses: actions-rs/toolchain@v1
with:
toolchain: 1.72
default: true
- name: Cache Cargo
uses: actions/cache@v3
with:
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/test-upstream.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ jobs:
channel-priority: strict
activate-environment: dask-sql
environment-file: ${{ env.CONDA_FILE }}
- uses: actions-rs/toolchain@v1
with:
toolchain: 1.72
default: true
- name: Install x86_64-apple-darwin target
if: matrix.os == 'macos-latest'
run: rustup target add x86_64-apple-darwin
Expand Down Expand Up @@ -103,6 +107,10 @@ jobs:
use-mamba: true
python-version: "3.9"
channel-priority: strict
- uses: actions-rs/toolchain@v1
with:
toolchain: 1.72
default: true
- name: Install dependencies and nothing else
run: |
pip install -e . -vv
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,10 @@ jobs:
activate-environment: dask-sql
environment-file: ${{ env.CONDA_FILE }}
run-post: ${{ matrix.os != 'windows-latest' && 'true' || 'false' }}
- name: Cache Rust
uses: Swatinem/rust-cache@v2
- uses: actions-rs/toolchain@v1
with:
workspaces: dask_planner
shared-key: test
toolchain: 1.72
default: true
- name: Install x86_64-apple-darwin target
if: matrix.os == 'macos-latest'
run: rustup target add x86_64-apple-darwin
Expand Down Expand Up @@ -128,6 +127,10 @@ jobs:
use-mamba: true
python-version: "3.9"
channel-priority: strict
- uses: actions-rs/toolchain@v1
with:
toolchain: 1.72
default: true
- name: Install dependencies and nothing else
run: |
pip install -e . -vv
Expand Down
2 changes: 1 addition & 1 deletion docs/environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ dependencies:
- pygments>=2.7.1
- tabulate
- ucx-proc=*=cpu
- rust>=1.72
- rust=1.72
Loading