-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inifinite loop #1166
base: main
Are you sure you want to change the base?
Fix inifinite loop #1166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open an issue clearly describing the problem and then add a test for your changes here. The current change is definitely incorrect since it will break existing stuff
I removed the last two rows. I don't know full library guts, so I can not correctly understand the logic behind the intended behavior. But the code clearly shows contradiction. Also, I have a specific example where these rows caused an infinite loop, but this is a rather specific case. If it is suitable, I can add a test for this case. |
the current logic definitely behaves as intended for what it was added for, there is no contradiction. Yes, please add an example that is failing / causing an infinite loop |
I see: |
In case of absent
mode
paramater in the custom fsspec file system implementation removed rows caused infinite loop, as mentioned in comments several rows above