Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Series.quantile #517

Merged
merged 7 commits into from
Dec 11, 2023
Merged

Implement Series.quantile #517

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a4def92
Implement quantile
phofl Dec 11, 2023
9cd7e5c
Merge branch 'main' into quantile
crusaderky Dec 11, 2023
60f67cc
cosmetic
crusaderky Dec 11, 2023
6fdcaaa
test method
crusaderky Dec 11, 2023
fb0b229
Update dask_expr/_quantile.py
phofl Dec 11, 2023
2d76a98
Add docstring
phofl Dec 11, 2023
73de720
Add tests
phofl Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dask_expr/_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1404,7 +1404,8 @@ def quantile(self, q=0.5, method="default"):
algorithm (``'dask'``). If set to ``'tdigest'`` will use tdigest
for floats and ints and fallback to the ``'dask'`` otherwise.
"""
assert pd.api.types.is_numeric_dtype(self.dtype), self.dtype
if not pd.api.types.is_numeric_dtype(self.dtype):
raise TypeError(f"quantile() on non-numeric dtype {self.dtype}")
allowed_methods = ["default", "dask", "tdigest"]
if method not in allowed_methods:
raise ValueError("method can only be 'default', 'dask' or 'tdigest'")
Expand Down
7 changes: 7 additions & 0 deletions dask_expr/tests/test_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1669,6 +1669,13 @@ def test_quantile(df):
lib.Series([19.0, 79.0], index=[0.2, 0.8]),
)

with pytest.raises(AssertionError):
df.x.quantile(q=[]).compute()
Comment on lines +1672 to +1673
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pandas returns an empty series here. Doubt we care to diverge on such an edge case though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought this was kind of pointless, but I might put up a follow up anyway


ser = from_pandas(lib.Series(["a", "b", "c"]), npartitions=2)
with pytest.raises(TypeError, match="on non-numeric"):
ser.quantile()


def test_map_overlap_raises():
def func(x):
Expand Down