Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readthedocs build #626

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Fix readthedocs build #626

merged 5 commits into from
Aug 2, 2024

Conversation

fnattino
Copy link
Contributor

@fnattino fnattino commented Feb 9, 2024

build.os is now required in the readthedocs configuration file: https://blog.readthedocs.com/use-build-os-config/

@guillaumeeb
Copy link
Member

Thanks, I wanted to look at this too. Unfortunately it is still failing.

@fnattino
Copy link
Contributor Author

Apologies for the "intrusion", I noticed this failing in #623 and I thought I would help with some housekeeping with what I thought would be a quick fix 😄 .

Now readthedocs starts building, but it fails because sphinx >=5 is required by numpydoc. I tried to add the version requirement to docs/environment.yml, but somehow this is bypassed by readthedocs? https://readthedocs.org/projects/dask-jobqueue/builds/23397606/

I could maybe try to drop conda and switch to pip, also updating Python version (right now it is pinned to 3.8)?

@jacobtomlinson
Copy link
Member

This workaround from dask/dask-sphinx-theme#68 (comment) is probably also needed here.

@jacobtomlinson
Copy link
Member

jacobtomlinson commented Aug 2, 2024

This appears to have gone stale so I pushed a few commits to get it over the line, hope you don't mind @fnattino. The docs are now building successfully so I'm going to merge this in.

@jacobtomlinson jacobtomlinson merged commit 3ee6171 into dask:main Aug 2, 2024
2 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants