Migrate Slurm to use rockylinux #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds are passing again so I'm going to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the container that the Slurm container was previously based on hasn't been updated on Docker Hub for four years. However the GitHub repo is still active, you just have to clone and build the image yourself.
It felt easier to vendor in the
Dockerfileand add our modifications to install Python. Indask-dockerwe used to do a remote build, but sincedocker buildxwas made the default this got a lot harder, so I'm apprehensive to go down that road again. I also explored cloning the repo locally and building it before building the main container but usingdocker compose buildto build images for pushing doesn't support using cached images that are on Docker Hub.