Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Yet another P2P buffer rewrite #8359

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

hendrikmakait
Copy link
Member

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

github-actions bot commented Nov 17, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       27 files  ±  0         27 suites  ±0   12h 15m 30s ⏱️ + 8m 45s
  3 932 tests  -   4    3 812 ✔️  -   5     117 💤 +  2    3  -   1 
49 639 runs   - 52  47 286 ✔️  - 90  2 338 💤 +27  15 +11 

For more details on these failures, see this check.

Results for commit 6d87d7a. ± Comparison against base commit 412a0a9.

This pull request removes 12 and adds 8 tests. Note that renamed tests count towards both.
distributed.shuffle.tests.test_disk_buffer ‑ test_basic
distributed.shuffle.tests.test_disk_buffer ‑ test_exceptions
distributed.shuffle.tests.test_disk_buffer ‑ test_high_pressure_flush_with_exception
distributed.shuffle.tests.test_disk_buffer ‑ test_many[1000]
distributed.shuffle.tests.test_disk_buffer ‑ test_many[100]
distributed.shuffle.tests.test_disk_buffer ‑ test_many[2]
distributed.shuffle.tests.test_disk_buffer ‑ test_read_before_flush
distributed.shuffle.tests.test_memory_buffer ‑ test_basic
distributed.shuffle.tests.test_memory_buffer ‑ test_many[1000]
distributed.shuffle.tests.test_memory_buffer ‑ test_many[100]
…
distributed.shuffle.tests.test_storage_buffer ‑ test_basic[1 B]
distributed.shuffle.tests.test_storage_buffer ‑ test_exceptions
distributed.shuffle.tests.test_storage_buffer ‑ test_high_pressure_flush_with_exception
distributed.shuffle.tests.test_storage_buffer ‑ test_many[1000]
distributed.shuffle.tests.test_storage_buffer ‑ test_many[100]
distributed.shuffle.tests.test_storage_buffer ‑ test_many[2]
distributed.shuffle.tests.test_storage_buffer ‑ test_read_before_flush
distributed.tests.test_metrics ‑ test_context_meter_allow_offload
This pull request skips 1 test.
distributed.shuffle.tests.test_shuffle ‑ test_bad_disk

♻️ This comment has been updated with latest results.

@hendrikmakait hendrikmakait force-pushed the refator-p2p-buffer branch 2 times, most recently from b9c50b2 to 1564ab3 Compare November 30, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant