Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Refactor/clear up dom locations #595

Merged
merged 10 commits into from
Nov 30, 2018
Merged

Conversation

AtuyL
Copy link
Collaborator

@AtuyL AtuyL commented Nov 21, 2018

This PR refactors the DOM structure to fix #590.

Closes #590

@AtuyL AtuyL force-pushed the refactor/clear-up-dom-locations branch from b28ac5e to 27dd2c7 Compare November 23, 2018 01:39
@AtuyL AtuyL force-pushed the refactor/clear-up-dom-locations branch from 27dd2c7 to 1216463 Compare November 30, 2018 02:43
@martinheidegger
Copy link
Collaborator

Is it supposed to show the progress bar on the download screen?

screen shot 2018-11-30 at 12 11 50

@AtuyL
Copy link
Collaborator Author

AtuyL commented Nov 30, 2018

Yes, this is supposed to look like that. I plan to send another PR to make this bar more beautiful. Is that okay?
See #597 for how we think future design will look.

Copy link
Collaborator

@martinheidegger martinheidegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, sounds good for me, lets continue with that. I will make a notice in the react project

@AtuyL AtuyL merged commit 3a2f1c4 into master Nov 30, 2018
@martinheidegger martinheidegger deleted the refactor/clear-up-dom-locations branch November 30, 2018 04:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headers shown in Intro
2 participants