feat: add dtype kwarg support to fftfreq and rfftfreq
#885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2025
|
As this was discussed in the last workgroup meeting and received no objections, I'll go ahead and merge. Thanks, @ev-br for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
dtypekwarg tofftfreqandrfftfreq#717 by addingdtypekwarg support tofft.fftfreqandfft.rfftfreq.fftfreqandrfftfreqwith other creation functions in allowing one to specify an output data type. Currently, these two FFT APIs have no means of inferring an output dtype precision, and thus default to the default real-valued floating-point data type.