Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix side effect of setting env variables 'AWS_ACCESS_KEY_ID' and 'AWS_SECRET_ACCESS_KEY' #128

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix side effect of setting env variables 'AWS_ACCESS_KEY_ID' and 'AWS_SECRET_ACCESS_KEY' #128

wants to merge 2 commits into from

Commits on Apr 17, 2024

  1. Add failing test

    @ThomasMarwitzQC
    ThomasMarwitzQC committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    230fd28 View commit details
    Browse the repository at this point in the history

  2. Remove env setting side effect. 

    Env variables 'AWS_ACCESS_KEY_ID' and 'AWS_SECRET_ACCESS_KEY' are no longer set if they are not present in env. Before credentials were passed explicitely, this was necessary for authentication since there was no other mechanism implemented than to set the env variables.
    @ThomasMarwitzQC
    ThomasMarwitzQC committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4a65044 View commit details
    Browse the repository at this point in the history