Remove deprecated logic #80
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5851e6a.
janjagusch
commented
Jul 7, 2023
janjagusch
commented
Jul 7, 2023
| @@ -73,8 +72,7 @@ def get_store_from_url( | |||
| scheme = scheme_parts[0] | |||
|
|
|||
| if scheme not in scheme_to_store: | |||
| # If we can't find the scheme, we fall back to the old creation methods | |||
| return get_store(**url2dict(url)) | |||
| raise NotImplementedError | |||
There was a problem hiding this comment.
TODO: We need to implement the _from_parsed_url class method for all stores before removing all the deprecated logic.
TODO:: Put this into a separate PR.
janjagusch
commented
Jul 7, 2023
| @@ -66,11 +68,12 @@ def _create_filesystem(self) -> "S3FileSystem": | |||
| if not has_s3fs: | |||
| raise ImportError("Cannot find optional dependency s3fs.") | |||
|
|
|||
| if "127.0.0.1" in self.endpoint_url: | |||
| if self.endpoint_url: | |||
There was a problem hiding this comment.
This line made no sense to me and I need to pass a custom endpoint URL to the filesystem.
TOOD: Move into separate PR.
janjagusch
commented
Jul 7, 2023
| return S3FileSystem( | ||
| anon=False, | ||
| client_kwargs={ | ||
| "endpoint_url": self.endpoint_url, | ||
| "verify": self.verify, |
There was a problem hiding this comment.
I have a use case where I want to disable SSL verification.
TODO: Move into separate PR.
janjagusch
commented
Jul 7, 2023
| conn = getattr(boto, connect_func)( | ||
| access_key, secret_key, host=host, port=port, is_secure=is_secure | ||
| ) | ||
| raise NotImplementedError |
There was a problem hiding this comment.
We should be able to remove the entire function.
ivergara
reviewed
Jul 11, 2023
| @@ -1,11 +1,17 @@ | |||
| Changelog | |||
| ********* | |||
|
|
|||
| 2.0.0 | |||
| ===== | |||
| * Removed ``get_store``, ``url2dict``, ``extract_params``, and ``create_store``. | |||
There was a problem hiding this comment.
Suggested change
| * Removed ``get_store``, ``url2dict``, ``extract_params``, and ``create_store``. | |
| * Removed ``get_store``, ``url2dict``, ``extract_params``, and ``create_store``. | |
| * Removed `BotoStore` based on deprecated `boto` library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP