Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement _from_parsed_url for (H)DictStore and add test #84

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

janjagusch
Copy link
Contributor

A first attempt at implementing _from_parsed_url for all stores. Here we start with the DictStore and also add a simple test scaffold.

Checklist

  • Added a docs/changes.rst entry

@janjagusch janjagusch marked this pull request as ready for review July 11, 2023 13:39
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7b40a87) 0.00% compared to head (04a48c9) 0.00%.
Report is 1 commits behind head on main.

❗ Current head 04a48c9 differs from pull request most recent head 0ac2454. Consider uploading reports for the commit 0ac2454 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #84   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         32      32           
  Lines       1988    1985    -3     
=====================================
+ Misses      1988    1985    -3     
Files Changed Coverage Δ
minimalkv/memory/__init__.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janjagusch janjagusch marked this pull request as draft July 24, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants