[PLUGIN-1824] ErrorDetailsProvider - MySql Source/Sink plugin #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psainics
changed the title
psainics
changed the title
| @@ -114,7 +119,7 @@ public void configurePipeline(PipelineConfigurer pipelineConfigurer) { | |||
|
|
|||
| if (sourceConfig.canConnect()) { | |||
| try { | |||
| stageConfigurer.setOutputSchema(getSchema(driverClass)); | |||
| stageConfigurer.setOutputSchema(getSchema(driverClass, collector)); | |||
There was a problem hiding this comment.
we are already adding the exception in failure collector below by catching it, why is this extra step needed?
There was a problem hiding this comment.
also can you please add sql state and error code in the message on line 127?
There was a problem hiding this comment.
Added SQL error details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorDetailsProvider - MySql [Source|Sink] plugin
Jira : PLUGIN-1824
Description
Implement Program Failure Exception Handling in MySql Source/Sink plugin to catch known errors
Code change
DBErrorDetailsProvider.javaMysqlErrorDetailsProvider.javaDBRecord.javaAbstractDBSink.javaAbstractDBSource.javaMysqlConstants.javaMysqlSink.javaMysqlSource.javaMysqlUtil.java