Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BQMT e2e fix #1464

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

AnkitCLI
Copy link
Contributor

@AnkitCLI AnkitCLI commented Nov 28, 2024

The PR contains fix for the Bigquery Multitable e2e failures on github actions.

@AnkitCLI AnkitCLI added the build Trigger unit test build label Nov 28, 2024
@AnkitCLI AnkitCLI changed the title debugging bqmt failures BQMT hooks changes Nov 28, 2024
@AnkitCLI AnkitCLI force-pushed the bqmt-hookchanges branch 2 times, most recently from d9c33a9 to 41d2c80 Compare November 28, 2024 19:28
@AnkitCLI AnkitCLI marked this pull request as ready for review November 29, 2024 04:21
@AnkitCLI AnkitCLI changed the title BQMT hooks changes BQMT e2e fix Nov 29, 2024
@@ -1327,7 +1330,7 @@ public static void createBucketWithLifeCycle() throws IOException, URISyntaxExce
@Before(order = 1, value = "@DATASTORE_SOURCE_ENTITY")
public static void createEntityInCloudDataStore() throws IOException, URISyntaxException {
kindName = "cdf-test-" + UUID.randomUUID().toString().substring(0, 8);
String entityName = DataStoreClient.createKind(kindName);
String entityName = DataStoreClient.createKind(kindName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: checkstyle

Copy link
Contributor Author

@AnkitCLI AnkitCLI Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

@psainics
Copy link
Contributor

All checks passed, LGTM, merging !

@psainics psainics merged commit b49a189 into data-integrations:develop Nov 29, 2024
16 checks passed
@psainics psainics deleted the bqmt-hookchanges branch November 29, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Trigger unit test build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants