Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLUGIN-1766] Added auto detection of number of rows and columns to read from. #45

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

vikasrathee-cs
Copy link
Contributor

[PLUGIN-1766]Added support to get all the rows and columns of google sheets instead of specifying the number each time.

Copy link
Member

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When Auto Detect Number of Rows and Columns is enabled, we should hide the existing fields Number of Columns to Read and Number of Rows to Read

For backward compatibility, we can keep it false by default?

docs/GoogleSheets-batchsource.md Outdated Show resolved Hide resolved
@vikasrathee-cs
Copy link
Contributor Author

When Auto Detect Number of Rows and Columns is enabled, we should hide the existing fields Number of Columns to Read and Number of Rows to Read

For backward compatibility, we can keep it false by default?

I have handled that on UI and backend both, in case of upgrade, it will be false and in new pipeline it will be true by default.

Copy link
Member

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment, can we add a validation check when autoDetectRowsAndColumns is set to false, lastDataRow & lastDataColumn should be > 0?

@vikasrathee-cs
Copy link
Contributor Author

vikasrathee-cs commented Mar 28, 2024

LGTM, just one comment, can we add a validation check when autoDetectRowsAndColumns is set to false, lastDataRow & lastDataColumn should be > 0?

That check is already there in method validateLastDataColumnIndexAndLastRowIndex

Added auto detection of number of rows and columns to read from
@vikasrathee-cs vikasrathee-cs merged commit e5f8b61 into data-integrations:develop Mar 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants