bug fix for using set-type when it's the first directive in the recipie #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanathi-g
reviewed
Dec 14, 2023
| Pair<Integer, Integer> scaleAndPrecision = getPrecisionAndScale(fieldSchema); | ||
| Integer inputSchemaScale = scaleAndPrecision.getSecond(); | ||
| Integer inputSchemaPrecision = scaleAndPrecision.getFirst(); | ||
| if (type.equalsIgnoreCase("decimal") && field.getSchema().isNullable()) { |
There was a problem hiding this comment.
What happens when schema is non nullable but set type directive is applied with 'decimal' as the type?
There was a problem hiding this comment.
If the schema is non nullable it will skip this if condition and will go to the return statement in line no:167. By default outputScale and outputPrecision are the scale and precision specified by the user. In this case we don't validate if the user specified scale and precision values clash with the original scale and precision values of that column.
| Integer inputSchemaScale = scaleAndPrecision.getSecond(); | ||
| Integer inputSchemaPrecision = scaleAndPrecision.getFirst(); | ||
| if (type.equalsIgnoreCase("decimal") && field.getSchema().isNullable()) { | ||
| Schema fieldSchema = field.getSchema().getNonNullable(); |
There was a problem hiding this comment.
Also, I think this giant block that calculates precision and scale to use can be moved to a different function. Can refactor the function used in .map()
minurajeeve
force-pushed
the
add-precision-option-in-decimal-bug-fix
branch
from
d07f02d to
6ffcfaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.