Added automatically generated acceptance tests for CLI commands #2501
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,48 @@ | ||||||
| # Code generated from OpenAPI specs by Databricks SDK Generator. DO NOT EDIT. | ||||||
| {{- $excludes := | ||||||
| list | ||||||
| "command-execution" | ||||||
|
There was a problem hiding this comment. Inconsistent indentation, spaces vs tabs. |
||||||
| "statement-execution" | ||||||
| "dbfs" | ||||||
| "dbsql-permissions" | ||||||
| "account-access-control-proxy" | ||||||
| "files" | ||||||
| "dashboards" | ||||||
| "queries-legacy" | ||||||
| }} | ||||||
|
|
||||||
| {{- $cmdGrp := .KebabName }} | ||||||
| {{- if or .HasParent (or .IsAccounts (in $excludes .KebabName)) }} | ||||||
| {{skipThisFile}} | ||||||
| {{- end}} | ||||||
| {{- $generated := false -}} | ||||||
| {{- $supportedMethods := list "get" "list" "list-pipelines" }} | ||||||
| {{- range .Methods}} | ||||||
| {{- if in $supportedMethods .KebabName}} | ||||||
|
There was a problem hiding this comment. You can inline
Suggested change
|
||||||
| {{- $generated = true }} | ||||||
| trace errcode $CLI {{$cmdGrp}} {{.KebabName}} {{ template "required-input" . }} | ||||||
| {{- end}} | ||||||
| {{- end}} | ||||||
|
|
||||||
| {{- if not $generated }} | ||||||
| {{skipThisFile}} | ||||||
| {{- end}} | ||||||
|
|
||||||
| {{- define "required-input" -}} | ||||||
| {{- range .RequiredPositionalArguments }}{{ template "param-value" . }} {{ end }} | ||||||
| {{- end -}} | ||||||
|
|
||||||
| {{- define "param-value" -}} | ||||||
| {{- if .Entity.IsString -}} | ||||||
| "input-{{.SnakeName}}" | ||||||
| {{- end}} | ||||||
| {{- if .Entity.IsNumber -}} | ||||||
| 42 | ||||||
| {{- end -}} | ||||||
| {{- if .Entity.IsEnum -}} | ||||||
| ENUM | ||||||
| {{- end -}} | ||||||
| {{- if .Entity.IsBool -}} | ||||||
| false | ||||||
| {{- end -}} | ||||||
| {{- end -}} | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| # Code generated from OpenAPI specs by Databricks SDK Generator. DO NOT EDIT. | ||
| {{- $excludes := | ||
| list | ||
| "command-execution" | ||
| "statement-execution" | ||
| "dbfs" | ||
| "dbsql-permissions" | ||
| "account-access-control-proxy" | ||
| "files" | ||
| "dashboards" | ||
| "queries-legacy" | ||
| }} | ||
|
|
||
| {{- $seen := list "" }} | ||
| {{- $cmdGrp := .KebabName }} | ||
| {{- if or .HasParent (or .IsAccounts (in $excludes .KebabName)) }} | ||
| {{skipThisFile}} | ||
| {{- end}} | ||
| {{- $generated := false -}} | ||
| {{- $supportedMethods := list "get" "list" "list-pipelines" }} | ||
| {{- range .Methods}} | ||
| {{- if in $supportedMethods .KebabName}} | ||
| {{- $generated = true }} | ||
|
|
||
| [[Server]] | ||
|
There was a problem hiding this comment. Instead of defining a server definition for every command, should we generate a FakeWorkspace, extending the idea in The advantage of fake workspace is eventually it'll be possible to do more CRUD-like autogenerated tests as well. It's also a more general interface, which can be useful in other contexts since it's basically a local simulation of a Databricks workspace. Writing the server in Go also allows us handle all sorts of API paths and support CREATE, DELETE etc since generating the server stubs in Go is a lot more powerful that generating them in |
||
| Pattern = "{{.Verb}} {{replaceAll "2.2" "2.1" .Path}}" | ||
|
There was a problem hiding this comment. Why do we need this replacement? |
||
| Response.Body = ''' | ||
| {{- if .Response.ArrayValue }} | ||
| {{ template "response-body-array" dict "SnakeName" .Response.SnakeName "Response" .Response "Seen" $seen }} | ||
| {{- else}} | ||
| {{ template "response-body" dict "Response" .Response "Seen" $seen }} | ||
| {{- end}} | ||
| ''' | ||
| {{- end}} | ||
| {{- end}} | ||
|
|
||
| {{- if not $generated }} | ||
| {{skipThisFile}} | ||
| {{- end}} | ||
|
|
||
| {{- define "response-body" -}} | ||
| {{- $seen := .Seen -}} | ||
| { | ||
| {{- $fields := .Response.Fields}} | ||
| {{- range $i, $f := $fields}} | ||
| {{- if (not (eq .SnakeName "next_page_token")) }} | ||
| "{{.SnakeName}}": {{ template "value" dict "Key" .SnakeName "Entity" .Entity "Seen" $seen "Indent" 0}}{{if notLast $i $fields}},{{end}} | ||
| {{- else}} | ||
| "{{.SnakeName}}": ""{{if notLast $i $fields}},{{end}} | ||
| {{- end}} | ||
| {{- end}} | ||
| } | ||
| {{- end -}} | ||
|
|
||
| {{- define "response-body-array" -}} | ||
| {{ template "value" dict "Key" .SnakeName "Entity" .Response "Seen" .Seen "Indent" 0}} | ||
| {{- end -}} | ||
|
|
||
| {{- define "value" -}} | ||
| {{- $seen := .Seen }} | ||
| {{- $indent := add .Indent 4 }} | ||
| {{- $key := .Key }} | ||
| {{- if .Entity.IsString -}} | ||
| "{{ $key }}" | ||
| {{- else if .Entity.IsNumber -}} | ||
| 42 | ||
| {{- else if .Entity.IsEnum -}} | ||
| "ENUM" | ||
| {{- else if .Entity.IsBool -}} | ||
| false | ||
| {{- else if .Entity.IsMap -}} | ||
| { | ||
| {{- $fields := .Entity.Fields }} | ||
| {{- range $i, $f := $fields}} | ||
| {{ indent $indent}}"{{.Name}}": {{template "value" dict "Key" .Name "Entity" .Entity.MapValue "Seen" $seen "Indent" $indent }}{{if notLast $i $fields}},{{end}} | ||
| {{- end }} | ||
| {{ indent $indent}}} | ||
| {{- else if .Entity.IsObject -}} | ||
| { | ||
| {{- $objName := .Entity.KebabName }} | ||
| {{- if not (in $seen $objName) }} | ||
| {{- range .Entity.Package.Types}} | ||
| {{- if eq .KebabName $objName}} | ||
| {{- $seen := append $seen .KebabName }} | ||
| {{- $fields := .Fields }} | ||
| {{- range $i, $f := $fields}} | ||
| {{ indent $indent}}"{{.Name}}": {{ template "value" dict "Key" .Name "Entity" .Entity "Seen" $seen "Indent" $indent }}{{if notLast $i $fields}},{{end}} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{ indent $indent}}} | ||
| {{- else if .Entity.IsArray -}} | ||
| [ | ||
| {{ indent $indent}}{{ template "value" dict "Key" .Entity.SnakeName "Entity" .Entity.ArrayValue "Seen" $seen "Indent" $indent }} | ||
| {{ indent $indent}}] | ||
| {{- else -}} | ||
| null | ||
| {{- end }} | ||
| {{- end -}} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but we can also remove
go fmt ./...ref: https://arc.net/l/quote/widxburh