-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve issue with AttributeError during update of Serving Endpoint tags #713
base: main
Are you sure you want to change the base?
Conversation
…int tags Signed-off-by: Volodymyr Pivoshenko <volodymyr.pivoshenko@gmail.com>
Signed-off-by: Volodymyr Pivoshenko <40499728+pivoshenko@users.noreply.github.com>
Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes. |
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Hi, thanks for the SDK it's really useful! I noticed today that when you try to update tags in the serving endpoint using the
patch
method it fails withAttributeError
. The fix is very straightforward. 🐱Changes
I just updated the way how responses are unpacked and passed into
EndpointTag
Tests
I tested it using my personal dev account.
make test
run locallymake fmt
appliedThanks!