Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented DataFrame.lookup #1785

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Implemented DataFrame.lookup #1785

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
090c8e0
Implemented DataFrame.lookup
itholic Sep 22, 2020
dfdb918
fix doctest
itholic Sep 22, 2020
9500b50
Added tests and fixed related codes
itholic Sep 22, 2020
ad7e4b2
fix pd.Series -> ks.Series
itholic Sep 22, 2020
4ee0228
use np.asarray instead of to_numpy()
itholic Sep 23, 2020
6e8642a
dont support for Index and Series
itholic Sep 24, 2020
612043b
Empty commit for rebuilding
itholic Sep 24, 2020
eb65fb6
Resolve conflicts
itholic Sep 26, 2020
9800752
Addressed comments
itholic Sep 26, 2020
2303f48
Remove tests from pandas directly
itholic Sep 26, 2020
db4b6d6
Resolve comments
itholic Jan 11, 2021
5227ef9
Merge branch 'master' of https://github.com/databricks/koalas into f_…
itholic Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion databricks/koalas/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10277,7 +10277,7 @@ def lookup(self, row_labels, col_labels) -> np.ndarray:
lookups = [
self.loc[row_label, col_label] for row_label, col_label in zip(row_labels, col_labels)
]
return Series(lookups).to_numpy()
return np.asarray(pd.Series(lookups))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why did we change it to np.asarray(pd.Series(lookups))?


def _to_internal_pandas(self):
"""
Expand Down