Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tf ci #166

Closed
wants to merge 19 commits into from
Closed

Feature/tf ci #166

wants to merge 19 commits into from

Conversation

atrakic
Copy link

@atrakic atrakic commented Dec 1, 2024

Related to #161. Adds a basic CI for the /modules.
Note: I had to update some of the modules in order to pass CI.

@atrakic atrakic requested review from a team as code owners December 1, 2024 20:06
jobs:
terraform:
name: 'Terraform CI'
runs-on: ubuntu-latest
Copy link
Collaborator

@alexott alexott Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to run it on Databricks-managed runners, like this:

https://github.com/databricks/terraform-provider-databricks/pull/4080/files

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, but I get "Access forbidden from this IP address" when I follow the link.
Any chance allowing running this ci job on gh hosted runners?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the link

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this would work for prs from non gh org members. I'm closing this one for now.

@atrakic atrakic closed this Dec 3, 2024
@atrakic
Copy link
Author

atrakic commented Dec 3, 2024

Not applicable due to gh runner restrictions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants