Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.37-nov 19] #106

Merged
merged 12 commits into from
Nov 19, 2024
Merged

[0.37-nov 19] #106

merged 12 commits into from
Nov 19, 2024

Conversation

jnyi
Copy link
Collaborator

@jnyi jnyi commented Nov 19, 2024

fix store bug: thanos-io#7904
fix bucket close: thanos-io#7915

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

simonpasquier and others added 11 commits November 8, 2024 09:57
Prometheus v3.0.0-rc.0 introduces a new scrape protocol
(`PrometheusText1.0.0`) which is present by default in the global
configuration. It breaks the Thanos sidecar when it wants to retrieve
the external labels.

This change replaces the use of the Prometheus `GlobalConfig` struct by
a minimal struct which unmarshals only the `external_labels` key.

See also prometheus-operator/prometheus-operator#7078

Signed-off-by: Simon Pasquier <[email protected]>
* fix store debug matchers panic on regex

Signed-off-by: Ben Ye <[email protected]>

* add test

Signed-off-by: Ben Ye <[email protected]>

* changelog

Signed-off-by: Ben Ye <[email protected]>

---------

Signed-off-by: Ben Ye <[email protected]>
* support hedged requests in store

Signed-off-by: milinddethe15 <[email protected]>

* hedged roundtripper with tdigest for dynamic delay

Signed-off-by: milinddethe15 <[email protected]>

* refactor struct and fix lint

Signed-off-by: milinddethe15 <[email protected]>

* Improve hedging implementation

Signed-off-by: milinddethe15 <[email protected]>

* Improved hedging implementation

Signed-off-by: milinddethe15 <[email protected]>

* Update store doc

Signed-off-by: milinddethe15 <[email protected]>

* fix white space

Signed-off-by: milinddethe15 <[email protected]>

* add enabled field

Signed-off-by: milinddethe15 <[email protected]>

---------

Signed-off-by: milinddethe15 <[email protected]>
I always get this in logs:
```
err: receive capnp conn: close tcp ...: use of closed network connection
```

This is also visible in the e2e test.

After Done() returns, the connection is closed either way so no need to
close it again.

Signed-off-by: Giedrius Statkevičius <[email protected]>
* Fix a storage GW bug that loses TSDB infos when joining them
* E2E test demonstrating a bug in the MinT calculation in distributed
  Engine

Signed-off-by: Michael Hoffmann <[email protected]>
…o#7915)

* always close block series client at the end

Signed-off-by: Ben Ye <[email protected]>

* add back close for loser tree

Signed-off-by: Ben Ye <[email protected]>

---------

Signed-off-by: Ben Ye <[email protected]>
* Update objstore and promql-engine to latest

Signed-off-by: Saswata Mukherjee <[email protected]>

* Fixes after upgrade

Signed-off-by: Saswata Mukherjee <[email protected]>

---------

Signed-off-by: Saswata Mukherjee <[email protected]>
@jnyi jnyi requested a review from yulong-db November 19, 2024 20:18
@jnyi jnyi merged commit b0aff72 into databricks:db_main Nov 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants