Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature generate from data revised #204

Open
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

ronanstokes-db
Copy link
Contributor

@ronanstokes-db ronanstokes-db commented Apr 11, 2023

Proposed changes

Improves code generation from existing data and analysis of existing data to determine possible categorical values in data being analyzed.

Additional minor improvements in code generation

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement to existing feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • [] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from prospector / lint

Further comments

Part of ongoing enhancements to code generation from existing data

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (1c8b340) 92.19% compared to head (d6f14eb) 91.17%.
Report is 3 commits behind head on master.

Files Patch % Lines
dbldatagen/data_analyzer.py 81.22% 40 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   92.19%   91.17%   -1.03%     
==========================================
  Files          23       23              
  Lines        2754     2968     +214     
  Branches      471      512      +41     
==========================================
+ Hits         2539     2706     +167     
- Misses        128      168      +40     
- Partials       87       94       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ronanstokes-db ronanstokes-db self-assigned this Apr 12, 2023
@ronanstokes-db ronanstokes-db added the enhancement New feature or request label Apr 12, 2023
@ronanstokes-db ronanstokes-db added this to the v0.4.0 milestone Apr 12, 2023
Copy link

@howardwu-db howardwu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to get some more clarify on the categoricalvaluesthreshold comment

_CODE_GENERATION_INDENT = 4
_MEASURE_ROUNDING = 4

# tuple for column infor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infor -- needs to be info

dbldatagen/data_analyzer.py Outdated Show resolved Hide resolved
dbldatagen/data_analyzer.py Outdated Show resolved Hide resolved
Copy link

@howardwu-db howardwu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need some minor editing changes

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants