-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature generate from data revised #204
base: master
Are you sure you want to change the base?
Conversation
merged from remote
merged of changes from remote
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 92.19% 91.17% -1.03%
==========================================
Files 23 23
Lines 2754 2968 +214
Branches 471 512 +41
==========================================
+ Hits 2539 2706 +167
- Misses 128 168 +40
- Partials 87 94 +7 ☔ View full report in Codecov by Sentry. |
…om/databrickslabs/dbldatagen into feature_generate_from_data_revised merge from remote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to get some more clarify on the categoricalvaluesthreshold comment
_CODE_GENERATION_INDENT = 4 | ||
_MEASURE_ROUNDING = 4 | ||
|
||
# tuple for column infor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
infor -- needs to be info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need some minor editing changes
min changes
removed trailing new lines
…om/databrickslabs/dbldatagen into feature_generate_from_data_revised pull from remote
Proposed changes
Improves code generation from existing data and analysis of existing data to determine possible categorical values in data being analyzed.
Additional minor improvements in code generation
Types of changes
What types of changes does your code introduce to dbldatagen?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Part of ongoing enhancements to code generation from existing data