Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added acc and make_acc_group fixtures #42

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Added acc and make_acc_group fixtures #42

merged 1 commit into from
Sep 18, 2024

Conversation

nfx
Copy link
Collaborator

@nfx nfx commented Sep 18, 2024

In this update, two new fixtures acc and make_acc_group have been introduced in the open-source library to enhance the testing capabilities of Databricks AccountClient objects and related functionalities. The acc fixture provides a Databricks AccountClient object for interacting with the Databricks account API, requiring the DATABRICKS_ACCOUNT_ID environment variable. The make_acc_group fixture, on the other hand, is designed for managing Databricks account groups, similar to the make_group fixture but utilizing the account client. These fixtures will allow for more comprehensive testing of Databricks account groups and their associated functionalities, improving the library's overall test coverage.

Copy link

This PR breaks backwards compatibility for databrickslabs/blueprint downstream. See build logs for more details.

Running from downstreams #12

Copy link

✅ 29/29 passed, 3 skipped, 1m55s total

Running from acceptance #52

@nfx nfx merged commit 5a87ecd into main Sep 18, 2024
8 of 9 checks passed
@nfx nfx deleted the feat/acc branch September 18, 2024 10:45
nfx added a commit that referenced this pull request Sep 18, 2024
* Added `acc` and `make_acc_group` fixtures ([#42](#42)). In this release, we have added two new fixtures, `acc` and `make_acc_group`, to the open-source library. The `acc` fixture provides a Databricks AccountClient object for use in tests, which can interact with the Databricks account API and automatically determines the account host from the `DATABRICKS_HOST` environment variable. The `make_acc_group` fixture is used for managing Databricks account groups, creating them with specified members and roles, and automatically deleting them after the test is complete. This fixture mirrors the behavior of the `make_group` fixture but interacts with the account client instead of the workspace client. These fixtures enable more comprehensive integration tests for the `acc` object and its various methods, enhancing the testing and management of Databricks account groups.
@nfx nfx mentioned this pull request Sep 18, 2024
nfx added a commit that referenced this pull request Sep 18, 2024
* Added `acc` and `make_acc_group` fixtures
([#42](#42)). In this
release, we have added two new fixtures, `acc` and `make_acc_group`, to
the open-source library. The `acc` fixture provides a Databricks
AccountClient object for use in tests, which can interact with the
Databricks account API and automatically determines the account host
from the `DATABRICKS_HOST` environment variable. The `make_acc_group`
fixture is used for managing Databricks account groups, creating them
with specified members and roles, and automatically deleting them after
the test is complete. This fixture mirrors the behavior of the
`make_group` fixture but interacts with the account client instead of
the workspace client. These fixtures enable more comprehensive
integration tests for the `acc` object and its various methods,
enhancing the testing and management of Databricks account groups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant