Add Volume Fixture #72
Merged
+133
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
requested changes
Oct 30, 2024
| def test_make_volume(): | ||
| ctx, info = call_stateful(make_volume) | ||
|
|
||
| ctx['ws'].volumes.create.assert_called_once() |
There was a problem hiding this comment.
can you assert on the actual arguments? :) then we're good to merge
There was a problem hiding this comment.
PTAL after changes
tests/unit/fixtures/test_catalog.py
Outdated
| def test_make_volume_with_name(): | ||
| ctx, info = call_stateful(make_volume, name='test_volume') | ||
|
|
||
| ctx['ws'].volumes.create.assert_called_once() |
There was a problem hiding this comment.
can you assert on the actual arguments? :) then we're good to merge
There was a problem hiding this comment.
PTAL after changes
christophergrant
had a problem deploying
to
account-admin
GitHub Actions
Failure
nfx
added a commit
that referenced
this pull request
Nov 4, 2024
* Added Volume Fixture ([#72](#72)). This commit introduces a Managed Volume fixture, `make_volume`, to the Unity Catalog in the test suite, facilitating the creation and use of a random volume for testing purposes. The fixture, when called without arguments, generates a volume with a random name. Alternatively, specifying the `name` argument creates a volume with the given name, using the `MANAGED` volume type, and associating it with a randomly generated catalog and schema. This promotes test isolation and prevents unintended interference. Additionally, this PR resolves issue [#70](#70) and includes unit and integration tests that have been manually verified to ensure the fixture's proper functioning. The commit also demonstrates a bug fix related to table retrieval in the `test_remove_after_property_table` test case.
Merged
nfx
added a commit
that referenced
this pull request
Nov 4, 2024
* Added Volume Fixture ([#72](#72)). This commit introduces a Managed Volume fixture, `make_volume`, to the Unity Catalog in the test suite, facilitating the creation and use of a random volume for testing purposes. The fixture, when called without arguments, generates a volume with a random name. Alternatively, specifying the `name` argument creates a volume with the given name, using the `MANAGED` volume type, and associating it with a randomly generated catalog and schema. This promotes test isolation and prevents unintended interference. Additionally, this PR resolves issue [#70](#70) and includes unit and integration tests that have been manually verified to ensure the fixture's proper functioning. The commit also demonstrates a bug fix related to table retrieval in the `test_remove_after_property_table` test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a Managed Volume fixture from Unity Catalog, allowing testers to create and use a random volume in the catalog.
Linked issues
Resolves #70 .
Tests