Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for like() function #130

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

chirag-s-db
Copy link
Contributor

@chirag-s-db chirag-s-db commented Mar 18, 2024

Adds support for the like() function, converting to a CONTAINS filter when possible (to take advantage of predicate pushdown).

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2024

CLA assistant check
All committers have signed the CLA.

@chirag-s-db chirag-s-db marked this pull request as ready for review March 18, 2024 19:42
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.03%. Comparing base (14789b6) to head (769f5b8).

Files Patch % Lines
...s/labs/transpiler/spl/catalyst/SplToCatalyst.scala 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   89.00%   89.03%   +0.03%     
==========================================
  Files          14       14              
  Lines         873      885      +12     
  Branches       42       41       -1     
==========================================
+ Hits          777      788      +11     
- Misses         96       97       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfx nfx merged commit b3586ef into databrickslabs:main Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants