Implement migration sequencing (phase 3) #3018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvergnaud
temporarily deployed
to
account-admin
GitHub Actions
Inactive
|
❌ 117/119 passed, 5 flaky, 2 failed, 8 skipped, 2h55m5s total ❌ test_migrate_managed_table_to_external_table_without_conversion: databricks.sdk.errors.platform.BadRequest: org.apache.hadoop.hive.ql.metadata.HiveException: MetaException(message:Got exception: shaded.databricks.CLOUD_ENVbfs.org.apache.hadoop.fs.CLOUD_ENVbfs.contracts.exceptions.KeyProviderException Failure to initialize configuration for storage account labsCLOUD_ENVTEST_MOUNT_NAME.dfs.core.windows.net: Invalid configuration value detected for fs.CLOUD_ENV.account.key) (3.303s)❌ test_migrate_managed_table_to_external_table_with_clone: databricks.sdk.errors.platform.BadRequest: org.apache.hadoop.hive.ql.metadata.HiveException: MetaException(message:Got exception: shaded.databricks.CLOUD_ENVbfs.org.apache.hadoop.fs.CLOUD_ENVbfs.contracts.exceptions.KeyProviderException Failure to initialize configuration for storage account labsCLOUD_ENVTEST_MOUNT_NAME.dfs.core.windows.net: Invalid configuration value detected for fs.CLOUD_ENV.account.key) (3.5s)Flaky tests:
Running from acceptance #7065 |
…-phase-2 # Conflicts: # src/databricks/labs/ucx/assessment/sequencing.py # tests/unit/assessment/test_sequencing.py
…-phase-3 # Conflicts: # tests/unit/assessment/test_sequencing.py
ericvergnaud
had a problem deploying
to
account-admin
GitHub Actions
Failure
# Conflicts: # src/databricks/labs/ucx/assessment/clusters.py # src/databricks/labs/ucx/assessment/jobs.py
…-phase-2 # Conflicts: # src/databricks/labs/ucx/framework/owners.py
…-phase-3 # Conflicts: # src/databricks/labs/ucx/assessment/sequencing.py
ericvergnaud
had a problem deploying
to
account-admin
GitHub Actions
Failure
ericvergnaud
had a problem deploying
to
account-admin
GitHub Actions
Failure
ericvergnaud
commented
Oct 25, 2024
| object_type="TABLE", | ||
| object_id=used_table.fullname, | ||
| object_name=used_table.fullname, | ||
| object_owner="", # TODO |
There was a problem hiding this comment.
Done in PR #3076
nfx
requested changes
Oct 31, 2024
| self, | ||
| ws: WorkspaceClient, | ||
| path_lookup: PathLookup, | ||
| admin_locator: AdministratorLocator, |
There was a problem hiding this comment.
inject TableOwnership via constructor, not the AdministratorLocator.
| @@ -15,6 +15,7 @@ | |||
| from databricks.labs.lsql.backends import SqlBackend | |||
| from databricks.sdk.errors import NotFound | |||
|
|
|||
| from databricks.labs.ucx.source_code.base import UsedTable | |||
There was a problem hiding this comment.
can we invert directionality and rewrite it as UsedTable.to_table()? src/databricks/labs/ucx/hive_metastore/tables.py shouldn't depend on the source_code package to avoid cycles.
JCZuurmond
force-pushed
the
migration-sequencing-phase-2
branch
from
3c34640
to
eb79746
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implement migration sequencing for used tables
Linked issues
Progresses #1415
Functionality
None
Tests