Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non UTF-8 encoded notebook error explicitly #3376

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Handle non UTF-8 encoded notebook error explicitly #3376

merged 2 commits into from
Nov 26, 2024
+17 −3

Conversation

JCZuurmond
Copy link
Contributor

@JCZuurmond JCZuurmond commented Nov 25, 2024 •
edited
Loading

Changes

Handle non UTF-8 encoded notebook error explicitly

Linked issues

Resolves #3374

Functionality

  • modified existing workflow: assessment

Tests

  • added unit tests

@JCZuurmond JCZuurmond added the migrate/code Abstract Syntax Trees and other dark magic label Nov 25, 2024
@JCZuurmond JCZuurmond self-assigned this Nov 25, 2024
@JCZuurmond JCZuurmond requested a review from a team as a code owner November 25, 2024 10:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

✅ 50/50 passed, 34m15s total

Running from acceptance #7544

@JCZuurmond JCZuurmond added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 07188c7 Nov 26, 2024
7 checks passed
@JCZuurmond JCZuurmond deleted the fix/non-unicoded-notebook branch November 26, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritishpai pritishpai pritishpai approved these changes

Assignees

@JCZuurmond JCZuurmond

Labels
migrate/code Abstract Syntax Trees and other dark magic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Failed parsing non-unicoded notebook
2 participants
@JCZuurmond @pritishpai