Case sensitive/insensitive table validation #3580
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ 3/3 passed, 2m45s total Running from acceptance #8144 |
FastLee
force-pushed
the
fix/case-sensitive-table-validation
branch
from
18ac91b to
bdff18c
Compare
JCZuurmond
requested changes
Jan 30, 2025
FastLee
force-pushed
the
fix/case-sensitive-table-validation
branch
from
c5a6d4f to
1ca97ab
Compare
JCZuurmond
approved these changes
Jan 31, 2025
| self._metadata_retriever = metadata_retriever | ||
| self._case_sensitive = case_sensitive | ||
|
|
||
| def _column_name_transformer(self) -> Callable[[str], str]: |
There was a problem hiding this comment.
More accurate would be to call it a factory here to signal it produces a callable
Suggested change
| def _column_name_transformer(self) -> Callable[[str], str]: | |
| def _column_name_transformer_factory(self) -> Callable[[str], str]: |
Comment on lines
+19
to
+21
| if self._case_sensitive: | ||
| return lambda _: _ | ||
| return str.lower |
There was a problem hiding this comment.
Suggested change
| if self._case_sensitive: | |
| return lambda _: _ | |
| return str.lower | |
| return str if self._case_sensitive else str.lower |
Comment on lines
+37
to
+42
| source_metadata = self._metadata_retriever.get_metadata( | ||
| source, column_name_transformer=self._column_name_transformer() | ||
| ) | ||
| target_metadata = self._metadata_retriever.get_metadata( | ||
| target, column_name_transformer=self._column_name_transformer() | ||
| ) |
There was a problem hiding this comment.
Does not really matter, but my OCD likes to initialize the transformer once. Also, I prefer the full names, but would accept a shorter name within a small code block to increase readability with all statements being single lines
Suggested change
| source_metadata = self._metadata_retriever.get_metadata( | |
| source, column_name_transformer=self._column_name_transformer() | |
| ) | |
| target_metadata = self._metadata_retriever.get_metadata( | |
| target, column_name_transformer=self._column_name_transformer() | |
| ) | |
| transformer = self._column_name_transformer() | |
| source_metadata = self._metadata_retriever.get_metadata(source, column_name_transformer=transformer) | |
| target_metadata = self._metadata_retriever.get_metadata(target, column_name_transformer=transformer) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3568
Added case sensitive flag for metadata comparison. To consider/ignore column name case.