Refactor JobsCrawler to add include_job_ids
#3658
Open
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanab-db
temporarily deployed
to
account-admin
GitHub Actions
Inactive
pritishpai
changed the title
JobsCrawler to add include_job_ids
|
✅ 29/29 passed, 5 skipped, 38m22s total Running from acceptance #8227 |
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Error
pritishpai
temporarily deployed
to
account-admin
GitHub Actions
Inactive
JCZuurmond
reviewed
Feb 7, 2025
There was a problem hiding this comment.
@mohanab-db : Thank you for reporting this issue and resolving it!
I have added some minor comments. A more fundamental implementation question would be: what is the bottle neck when crawling all the jobs?
Is the bottleneck:
- Listing all the jobs
- Listing all clusters
- Combining jobs with clusters
- Assessing the jobs (actually we only assess the clusters related to the jobs)
| @@ -94,9 +94,10 @@ def _job_clusters(job: BaseJob) -> Iterable[tuple[BaseJob, ClusterSpec]]: | |||
|
|
|||
|
|
|||
| class JobsCrawler(CrawlerBase[JobInfo], JobsMixin, CheckClusterMixin): | |||
| def __init__(self, ws: WorkspaceClient, sql_backend: SqlBackend, schema): | |||
| def __init__(self, ws: WorkspaceClient, sql_backend: SqlBackend, schema, include_job_ids: list[int] | None = None): | |||
There was a problem hiding this comment.
Suggested change
| def __init__(self, ws: WorkspaceClient, sql_backend: SqlBackend, schema, include_job_ids: list[int] | None = None): | |
| def __init__(self, ws: WorkspaceClient, sql_backend: SqlBackend, schema, *, include_job_ids: list[int] | None = None): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Check for include_job_ids in assess_jobs task
Linked issues
#3656
Resolves #..
Functionality
databricks labs ucx .........Tests