Fix notebook sources with NotebookLinter.apply
#3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
added
migrate/python
JCZuurmond
commented
Feb 14, 2025
| @@ -303,18 +304,36 @@ def test_notebook_linter_lints_source_yielding_parse_failures(migration_index, m | |||
| ] | |||
|
|
|||
|
|
|||
| def test_notebook_linter_lints_migrated_table(migration_index, mock_path_lookup) -> None: | |||
| def test_notebook_linter_lints_and_applies_migrated_table(tmp_path, migration_index, mock_path_lookup) -> None: | |||
There was a problem hiding this comment.
This test fails because the underlying linter does not support fixing the code yet when the value should be inferred instead of being a constant in the table call
|
|
||
| def test_notebook_linter_lints_migrated_table_with_rename(migration_index, mock_path_lookup) -> None: | ||
|
|
||
| def test_notebook_linter_lints_and_applies_migrated_table_with_rename( |
There was a problem hiding this comment.
This test fails because the underlying linter does not support fixing the code yet when the value should be inferred instead of being a constant in the table call
|
Unblocking this PR and tackling the issue in seperately: #3695 |
JCZuurmond
force-pushed
the
feat/add-notebook-fixing
branch
from
2663c6a to
7b63701
Compare
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Error
JCZuurmond
force-pushed
the
feat/add-notebook-fixing
branch
from
7b63701 to
5677dad
Compare
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
|
✅ 81/81 passed, 2 skipped, 41m47s total Running from acceptance #8346 |
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
FastLee
requested changes
Feb 14, 2025
| "https://github.com/databrickslabs/ucx/issues/new?title=Autofix+the+following+Python+code" | ||
| "&labels=migrate/code,needs-triage&type=Feature" | ||
| "&body=%23+Desired+behaviour%0A%0AAutofix+following+Python+code" | ||
| "%0A%0A%60%60%60+python%0ATODO:+Add+relevant+source+code%0A" |
There was a problem hiding this comment.
Create a link to doc method
There was a problem hiding this comment.
Could you clarify this change request? What is a "documentation method"?
1 task
JCZuurmond
force-pushed
the
feat/add-notebook-fixing
branch
from
5f54c81 to
dc46932
Compare
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
FastLee
approved these changes
Feb 19, 2025
pritishpai
approved these changes
Feb 19, 2025
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Error
Explain why the PythonFixer works like this
JCZuurmond
force-pushed
the
feat/add-notebook-fixing
branch
from
bb7fb9e to
6042657
Compare
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
FastLee
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add notebook fixing to
NotebookLinterNotebook.applyNotebook.applyfromFileLiner.applyforNotebooksource containerNotebookMigratorPythonLinterto run apply on a AST treeLinked issues
Progresses #3514
Breaks up #3520
Functionality
databricks labs ucx migrate-local-codeTests