Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for MSSQL and POSTGRESQL to HMS Federation #3701

Merged
merged 6 commits into from
Feb 19, 2025
Merged

Added support for MSSQL and POSTGRESQL to HMS Federation #3701

merged 6 commits into from
Feb 19, 2025
+107 −35

Conversation

FastLee
Copy link
Contributor

@FastLee FastLee commented Feb 14, 2025

closes #3664

@FastLee FastLee requested a review from a team as a code owner February 14, 2025 19:59
@FastLee FastLee force-pushed the feat/hms_rdbms_support branch from c291628 to 83116af Compare February 14, 2025 20:01
@FastLee FastLee enabled auto-merge February 14, 2025 20:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

✅ 55/55 passed, 5 skipped, 3h59m50s total

Running from acceptance #8342

JCZuurmond
JCZuurmond requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@JCZuurmond JCZuurmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks GTM. Added some nits and clarification questions

src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Show resolved Hide resolved
@FastLee FastLee force-pushed the feat/hms_rdbms_support branch from 83116af to a22315f Compare February 18, 2025 18:34
@FastLee FastLee requested a review from JCZuurmond February 18, 2025 18:49
JCZuurmond
JCZuurmond approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@JCZuurmond JCZuurmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final questions, approving so that you can continue

src/databricks/labs/ucx/hive_metastore/federation.py Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Show resolved Hide resolved
src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
@FastLee FastLee force-pushed the feat/hms_rdbms_support branch from 585af28 to 8e5ecfa Compare February 19, 2025 15:24
@FastLee FastLee added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 01c4263 Feb 19, 2025
7 checks passed
@FastLee FastLee deleted the feat/hms_rdbms_support branch February 19, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCZuurmond JCZuurmond JCZuurmond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: HMS Federation - add support for Postgres and SQL Server
2 participants
@FastLee @JCZuurmond