Feature/revise pkg download #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does still count package from same ip multiple times
|
Fixes #358 |
ludov04
reviewed
Aug 8, 2017
| @@ -1,6 +1,9 @@ | |||
| var _ = require('lodash'); | |||
| var Promise = require('bluebird'); | |||
| var dateFormat = require('dateformat'); | |||
| var CSV = require('csv-js'); | |||
There was a problem hiding this comment.
you need to also add thoses package to package.json
There was a problem hiding this comment.
Probably removed it when removing other packages I added but didn't need eventually
jhoobergs
commented
Aug 9, 2017
| @@ -12,6 +12,7 @@ | |||
| "cheerio": "^0.20.0", | |||
| "connect-flash": "^0.1.1", | |||
| "connect-redis": "^3.1.0", | |||
| "csv-js": "^1.0.0", | |||
There was a problem hiding this comment.
@ludov04 Seems like I already did that
There was a problem hiding this comment.
@jhoobergs I missed it somehow, but zlib is still missing
There was a problem hiding this comment.
@ludov04 zlib is part of node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.