Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move directives out of the server block #175

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

digitaldogsbody
Copy link
Member

Purpose

Move the directives that need to be in the http block out of the server block. They are left in the webapp.conf file because it is included inside the http block of /etc/nginx/nginx.conf by the include /etc/nginx/sites-enabled/*; directive

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@digitaldogsbody digitaldogsbody requested a review from a team October 16, 2024 16:53
@digitaldogsbody digitaldogsbody merged commit 2a381b1 into master Oct 16, 2024
3 checks passed
@digitaldogsbody digitaldogsbody deleted the fix-passenger-config branch October 16, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants