Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create script to call usda quickstats api. #872

Merged
merged 13 commits into from
Aug 4, 2023
Merged

Create script to call usda quickstats api. #872

merged 13 commits into from
Aug 4, 2023

Conversation

keyurva
Copy link
Contributor

@keyurva keyurva commented Jul 28, 2023

No description provided.

@keyurva keyurva requested review from pradh and n-h-diaz July 28, 2023 16:00
@keyurva keyurva changed the title Create initial script to call usda quickstats api. Create script to call usda quickstats api. Jul 28, 2023
@keyurva keyurva requested a review from ajaits July 31, 2023 17:09
ajaits
ajaits reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@ajaits ajaits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dc_generated/* files can be removed. We don't need to add them into github.

ajaits
ajaits approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@ajaits ajaits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the parallelised script!

We can modify this to generate output to GCS as a followup PR for auto refresh.

@keyurva keyurva merged commit 2a9512b into datacommonsorg:master Aug 4, 2023
8 checks passed
shamimansari1988 pushed a commit to shamimansari1988/data that referenced this pull request Aug 12, 2024
@keyurva
Create script to call usda quickstats api. (datacommonsorg#872)
1ddfb1b 
* Create initial script to call usda quickstats api.

* Fetch all counties and generate CSV.

* Add dcs prefix to statvars.

* Generate CSVs for multiple years.

* Load api key from cloud or from command line.

* Fix formatting.

* Add test to verify processing into CSV.

* Add copyright text.

* Fix latlng recon test.

* Add comment on running the script with an API key.

* Comment out git parameters in test to see if it fixes cloud build.

* Revert integration_test.py changes.

* Attempt to fix a failing test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradh pradh pradh left review comments

@ajaits ajaits ajaits approved these changes

@n-h-diaz n-h-diaz Awaiting requested review from n-h-diaz

Assignees

@chejennifer chejennifer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keyurva @pradh @ajaits @chejennifer