Pluggable credentials #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an extra boolean parameter to the log category that allows it to be turned off by default, to support the 'recompile with verbose logging' use-case. This could be combined at a later stage with the ability to modify logging via environment variables or a SHM segment and a signal.
This change adds a mustSucceed flag to the kill() and signal() functions in Runner, which allows them to be called unconditionally. This is especially useful in shutdowns, where we don't want an exception if we tried to stop it but it was already stopped. The default behaviour remains the same: throw an exception. They will also return whether they succeded or not. TRIVIAL because semantics of any existing calls have not changed.
This makes it possible to avoid segmentation faults in the case where the remote end drops the connection. Previously it would lead to the connection object being deleted and a dangling pointer. Mostly relevant to long-running connections that are handled asynchronously. In the synchronous case the connection is locked for the duration and recycled afterwards, so it can't cause a problem.
|
(quoted) response from @jeremybarnes : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch refactors the credentials handling code in S3 to provide:
The idea here is to decouple credentials from the code that makes use of them, and allow for scenarios such as a daemon that provides short-lived credentials on demand or instance-based credentials on Amazon.
I'm primarily looking for comments on the design; please ignore the unfortunate noise in the early commits.