Fix DuckDBDialect creation according to DataFusion DuckDBDialect update

datafusion-contrib · Dec 20, 2024 · 33f13ce · 33f13ce
1 parent 91f92f5
commit 33f13ce
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -102,8 +102,8 @@ postgres-federation = ["postgres"]
 datafusion-federation = { git = "https://github.com/spiceai/datafusion-federation.git", rev = "5af0df83c2cd1d3f82f293b066b401a4dfd4064b" }
 duckdb = { git = "https://github.com/spiceai/duckdb-rs.git", rev = "d6f8c3e0dc1ba073a86756eba4dacf044dfa892d" }
 
-datafusion = { git = "https://github.com/spiceai/datafusion.git", rev = "aaa46be22cff778e0e618b5eaeee3c2830d4e7ee"}
-datafusion-expr =  { git = "https://github.com/spiceai/datafusion.git", rev = "aaa46be22cff778e0e618b5eaeee3c2830d4e7ee"}
-datafusion-physical-expr =  { git = "https://github.com/spiceai/datafusion.git", rev = "aaa46be22cff778e0e618b5eaeee3c2830d4e7ee"}
-datafusion-physical-plan =  { git = "https://github.com/spiceai/datafusion.git", rev = "aaa46be22cff778e0e618b5eaeee3c2830d4e7ee"}
-datafusion-proto =  { git = "https://github.com/spiceai/datafusion.git", rev = "aaa46be22cff778e0e618b5eaeee3c2830d4e7ee"}
+datafusion = { git = "https://github.com/spiceai/datafusion.git", rev = "37f0f144650db9e07a09c02fdbb69179438316be"}
+datafusion-expr =  { git = "https://github.com/spiceai/datafusion.git", rev = "37f0f144650db9e07a09c02fdbb69179438316be"}
+datafusion-physical-expr =  { git = "https://github.com/spiceai/datafusion.git", rev = "37f0f144650db9e07a09c02fdbb69179438316be"}
+datafusion-physical-plan =  { git = "https://github.com/spiceai/datafusion.git", rev = "37f0f144650db9e07a09c02fdbb69179438316be"}
+datafusion-proto =  { git = "https://github.com/spiceai/datafusion.git", rev = "37f0f144650db9e07a09c02fdbb69179438316be"}
diff --git a/src/duckdb.rs b/src/duckdb.rs
@@ -155,7 +155,7 @@ impl DuckDBTableProviderFactory {
             access_mode,
             instances: Arc::new(Mutex::new(HashMap::new())),
             invalid_type_action: InvalidTypeAction::Error,
-            dialect: Arc::new(DuckDBDialect {}),
+            dialect: Arc::new(DuckDBDialect::new()),
         }
     }
 
@@ -509,7 +509,7 @@ impl DuckDBTableFactory {
     pub fn new(pool: Arc<DuckDbConnectionPool>) -> Self {
         Self {
             pool,
-            dialect: Arc::new(DuckDBDialect {}),
+            dialect: Arc::new(DuckDBDialect::new()),
         }
     }
 

diff --git a/src/duckdb/sql_table.rs b/src/duckdb/sql_table.rs
@@ -54,7 +54,7 @@ impl<T, P> DuckDBTable<T, P> {
             table_reference,
             Some(Engine::DuckDB),
         )
-        .with_dialect(dialect.unwrap_or(Arc::new(DuckDBDialect {})));
+        .with_dialect(dialect.unwrap_or(Arc::new(DuckDBDialect::new())));
 
         Self {
             base_table,